Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASL-592 Extension Cleanup Capability #374

Merged
merged 43 commits into from
Jan 16, 2025

Conversation

rlakde
Copy link
Member

@rlakde rlakde commented Oct 30, 2024

No description provided.

rlakde and others added 14 commits August 19, 2024 11:38
Signed-off-by: lakde <rohit.lakde@here.com>
Signed-off-by: lakde <rohit.lakde@here.com>
Signed-off-by: lakde <rohit.lakde@here.com>
* Fixed array patching (#365)

* Fixed array patching
* corrected patcher test expectation

* Fix thread stuck issue + addtnl logs (#368)

* Added logs to troubleshoot thread hanging issue
* CASL-258 unreleased lock fix (#358)
* Fixed array patching (#365) (#367)
* corrected patcher test expectation
* updated version
* updated changelog
---------

Co-authored-by: Pawel Mazurek <52866094+cyberhead-pl@users.noreply.github.com>

---------

Co-authored-by: Hiren Patel <80465571+hirenkp2000@users.noreply.github.com>
Co-authored-by: Pawel Mazurek <52866094+cyberhead-pl@users.noreply.github.com>
Copy link

Code Coverage

Overall Project 42.68% -0.3% 🍏
Files changed 31.9% 🍏

Module Coverage
here-naksha-lib-ext-manager 72.1% -9.49% 🍏
here-naksha-lib-core 32.8% -0.02% 🍏
here-naksha-lib-hub 25.01% -5.8% 🍏
Files
Module File Coverage
here-naksha-lib-ext-manager ExtensionCache.java 74.3% -14.96% 🍏
AmazonS3Helper.java 59.57% 🍏
here-naksha-lib-core Extension.java 0% -24.14% 🍏
ExtensionConfig.java 0% -9.09% 🍏
here-naksha-lib-hub NakshaHub.java 1.43% -18.64% 🍏

Copy link

github-actions bot commented Nov 4, 2024

Code Coverage

Overall Project 42.65% -0.33% 🍏
Files changed 30.08% 🍏

Module Coverage
here-naksha-lib-ext-manager 70.45% -11.56% 🍏
here-naksha-lib-core 32.8% -0.02% 🍏
here-naksha-lib-hub 25.01% -5.8% 🍏
Files
Module File Coverage
here-naksha-lib-ext-manager ExtensionCache.java 74.3% -14.96% 🍏
AmazonS3Helper.java 59.57% 🍏
ValueTuple.java 0% 🍏
here-naksha-lib-core Extension.java 0% -24.14% 🍏
ExtensionConfig.java 0% -9.09% 🍏
here-naksha-lib-hub NakshaHub.java 1.43% -18.64% 🍏

Copy link

github-actions bot commented Nov 4, 2024

Code Coverage

Overall Project 42.68% -0.28% 🍏
Files changed 38.4% 🍏

Module Coverage
here-naksha-lib-ext-manager 73.99% -7.25% 🍏
here-naksha-lib-core 32.81% -0.02% 🍏
here-naksha-lib-hub 25.01% -5.8% 🍏
Files
Module File Coverage
here-naksha-lib-ext-manager ValueTuple.java 100% 🍏
ExtensionCache.java 76.54% -12.12% 🍏
AmazonS3Helper.java 59.57% 🍏
here-naksha-lib-core Extension.java 0% -24.14% 🍏
ExtensionConfig.java 0% -9.09% 🍏
here-naksha-lib-hub NakshaHub.java 1.43% -18.64% 🍏

Copy link

github-actions bot commented Nov 4, 2024

Code Coverage

Overall Project 42.68% -0.28% 🍏
Files changed 38.29% 🍏

Module Coverage
here-naksha-lib-ext-manager 73.99% -7.25% 🍏
here-naksha-lib-core 32.81% -0.02% 🍏
here-naksha-lib-hub 25% -5.83% 🍏
Files
Module File Coverage
here-naksha-lib-ext-manager ValueTuple.java 100% 🍏
ExtensionCache.java 76.54% -12.12% 🍏
AmazonS3Helper.java 59.57% 🍏
here-naksha-lib-core Extension.java 0% -24.14% 🍏
ExtensionConfig.java 0% -9.09% 🍏
here-naksha-lib-hub NakshaHub.java 1.43% -18.75% 🍏

Copy link

github-actions bot commented Nov 5, 2024

Code Coverage

Overall Project 42.68% -0.28% 🍏
Files changed 38.29% 🍏

Module Coverage
here-naksha-lib-ext-manager 73.99% -7.25% 🍏
here-naksha-lib-core 32.8% -0.02% 🍏
here-naksha-lib-hub 25% -5.83% 🍏
Files
Module File Coverage
here-naksha-lib-ext-manager ValueTuple.java 100% 🍏
ExtensionCache.java 76.54% -12.12% 🍏
AmazonS3Helper.java 59.57% 🍏
here-naksha-lib-core Extension.java 0% -24.14% 🍏
ExtensionConfig.java 0% -9.09% 🍏
here-naksha-lib-hub NakshaHub.java 1.43% -18.75% 🍏

Copy link

github-actions bot commented Nov 5, 2024

Code Coverage

Overall Project 42.67% -0.25% 🍏
Files changed 38.82% 🍏

Module Coverage
here-naksha-lib-ext-manager 75.39% -5.23% 🍏
here-naksha-lib-core 32.8% -0.02% 🍏
here-naksha-lib-hub 25% -5.83% 🍏
Files
Module File Coverage
here-naksha-lib-ext-manager ValueTuple.java 100% 🍏
ExtensionCache.java 79.07% -8.94% 🍏
AmazonS3Helper.java 59.57% 🍏
here-naksha-lib-core Extension.java 0% -24.14% 🍏
ExtensionConfig.java 0% -9.09% 🍏
here-naksha-lib-hub NakshaHub.java 1.43% -18.75% 🍏

Copy link

Code Coverage

Overall Project 42.66% -0.22% 🍏
Files changed 22.77% 🍏

Module Coverage
here-naksha-lib-ext-manager 73.76% -2.6% 🍏
here-naksha-lib-core 32.8% -0.02% 🍏
here-naksha-lib-hub 25.01% -5.8% 🍏
Files
Module File Coverage
here-naksha-lib-ext-manager ExtensionCache.java 81.05% 🍏
AmazonS3Helper.java 59.57% 🍏
ValueTuple.java 0% 🍏
here-naksha-lib-core Extension.java 0% -24.14% 🍏
ExtensionConfig.java 0% -9.09% 🍏
here-naksha-lib-hub NakshaHub.java 1.43% -18.64% 🍏

Copy link

Code Coverage

Overall Project 42.66% -0.22% 🍏
Files changed 22.77% 🍏

Module Coverage
here-naksha-lib-ext-manager 73.76% -2.6% 🍏
here-naksha-lib-core 32.8% -0.02% 🍏
here-naksha-lib-hub 25.01% -5.8% 🍏
Files
Module File Coverage
here-naksha-lib-ext-manager ExtensionCache.java 81.05% 🍏
AmazonS3Helper.java 59.57% 🍏
ValueTuple.java 0% 🍏
here-naksha-lib-core Extension.java 0% -24.14% 🍏
ExtensionConfig.java 0% -9.09% 🍏
here-naksha-lib-hub NakshaHub.java 1.43% -18.64% 🍏

Copy link

Code Coverage

Overall Project 42.69% -0.1% 🍏
Files changed 57.39% 🍏

Module Coverage
here-naksha-lib-ext-manager 74.7% -7.28% 🍏
here-naksha-lib-hub 25% -0.57% 🍏
Files
Module File Coverage
here-naksha-lib-ext-manager ValueTuple.java 100% 🍏
ExtensionCache.java 77.91% -12.47% 🍏
here-naksha-lib-hub NakshaHub.java 1.43% -1.82% 🍏

Copy link

Code Coverage

Overall Project 42.69% -0.1% 🍏
Files changed 57.39% 🍏

Module Coverage
here-naksha-lib-ext-manager 74.7% -7.28% 🍏
here-naksha-lib-hub 25% -0.57% 🍏
Files
Module File Coverage
here-naksha-lib-ext-manager ValueTuple.java 100% 🍏
ExtensionCache.java 77.91% -12.47% 🍏
here-naksha-lib-hub NakshaHub.java 1.43% -1.82% 🍏

Copy link

Code Coverage

Overall Project 42.69% -0.1% 🍏
Files changed 57.39% 🍏

Module Coverage
here-naksha-lib-ext-manager 74.7% -7.28% 🍏
here-naksha-lib-hub 25% -0.57% 🍏
Files
Module File Coverage
here-naksha-lib-ext-manager ValueTuple.java 100% 🍏
ExtensionCache.java 77.91% -12.47% 🍏
here-naksha-lib-hub NakshaHub.java 1.43% -1.82% 🍏

Copy link

Code Coverage

Overall Project 42.67% -0.1% 🍏
Files changed 58.33% 🍏

Module Coverage
here-naksha-lib-ext-manager 74.7% -7.28% 🍏
here-naksha-lib-core 32.79% 🍏
here-naksha-lib-hub 25% -0.57% 🍏
Files
Module File Coverage
here-naksha-lib-ext-manager ValueTuple.java 100% 🍏
ExtensionCache.java 77.91% -12.47% 🍏
here-naksha-lib-core NakshaVersion.java 42.31% 🍏
here-naksha-lib-hub NakshaHub.java 1.43% -1.82% 🍏

Copy link

Code Coverage

Overall Project 42.67% -0.1% 🍏
Files changed 58.33% 🍏

Module Coverage
here-naksha-lib-ext-manager 74.7% -7.28% 🍏
here-naksha-lib-core 32.79% 🍏
here-naksha-lib-hub 25% -0.57% 🍏
Files
Module File Coverage
here-naksha-lib-ext-manager ValueTuple.java 100% 🍏
ExtensionCache.java 77.91% -12.47% 🍏
here-naksha-lib-core NakshaVersion.java 42.31% 🍏
here-naksha-lib-hub NakshaHub.java 1.43% -1.82% 🍏

Copy link

github-actions bot commented Jan 3, 2025

Code Coverage

Overall Project 42.68% -0.12% 🍏
Files changed 53.3% 🍏

Module Coverage
here-naksha-lib-ext-manager 74.7% -7.28% 🍏
here-naksha-lib-core 32.79% 🍏
here-naksha-lib-hub 24.8% -1.25% 🍏
Files
Module File Coverage
here-naksha-lib-ext-manager ValueTuple.java 100% 🍏
ExtensionCache.java 77.91% -12.47% 🍏
here-naksha-lib-core NakshaVersion.java 42.31% 🍏
here-naksha-lib-hub NakshaHub.java 1.42% -4.01% 🍏

* Updated doc about existing JWT loading
* added support for additional pub key
* updated readme
* Updated version to 2.2.1
* Updated doc for pvt and pub key
* Added constants in NakshaHubConfig constructor
* addressed review comments

Co-authored-by: Hiren Patel <80465571+hirenkp2000@users.noreply.github.com>
Copy link

github-actions bot commented Jan 3, 2025

Code Coverage

Overall Project 42.67% -0.18% 🍏
Files changed 55.02% 🍏

Module Coverage
here-naksha-lib-ext-manager 74.7% -7.28% 🍏
here-naksha-app-service 71.21% -0.13% 🍏
here-naksha-lib-core 32.79% 🍏
here-naksha-lib-hub 24.8% -2.61% 🍏
Files
Module File Coverage
here-naksha-lib-ext-manager ValueTuple.java 100% 🍏
ExtensionCache.java 77.91% -12.47% 🍏
here-naksha-app-service NakshaJwtAuthHandler.java 100% 🍏
NakshaApp.java 63.92% -2.23% 🍏
here-naksha-lib-core NakshaVersion.java 42.31% 🍏
here-naksha-lib-hub NakshaHubConfig.java 4.55% -9.66% 🍏
NakshaHub.java 1.42% -4.01% 🍏

Copy link

github-actions bot commented Jan 6, 2025

Code Coverage

Overall Project 42.69% -0.18% 🍏
Files changed 56.7% 🍏

Module Coverage
here-naksha-lib-ext-manager 74.91% -7.22% 🍏
here-naksha-app-service 71.21% -0.13% 🍏
here-naksha-lib-core 32.8% 🍏
here-naksha-lib-hub 24.8% -2.61% 🍏
Files
Module File Coverage
here-naksha-lib-ext-manager ValueTuple.java 100% 🍏
ExtensionCache.java 78.23% -12.3% 🍏
here-naksha-app-service NakshaJwtAuthHandler.java 100% 🍏
NakshaApp.java 63.92% -2.23% 🍏
here-naksha-lib-core NakshaVersion.java 42.31% 🍏
here-naksha-lib-hub NakshaHubConfig.java 4.55% -9.66% 🍏
NakshaHub.java 1.42% -4.01% 🍏

Copy link

Code Coverage

Overall Project 42.69% -0.08% 🍏
Files changed 65.73% 🍏

Module Coverage
here-naksha-lib-ext-manager 74.91% -7.22% 🍏
here-naksha-lib-core 32.79% 🍏
Files
Module File Coverage
here-naksha-lib-ext-manager ValueTuple.java 100% 🍏
ExtensionCache.java 78.23% -12.3% 🍏
here-naksha-lib-core NakshaVersion.java 42.31% 🍏

Copy link
Member

@hirenkp2000 hirenkp2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving

Copy link

Code Coverage

Overall Project 42.68% -0.08% 🍏
Files changed 65.95% 🍏

Module Coverage
here-naksha-lib-ext-manager 74.88% -7.39% 🍏
here-naksha-lib-core 32.79% 🍏
Files
Module File Coverage
here-naksha-lib-ext-manager ValueTuple.java 100% 🍏
ExtensionCache.java 78.13% -12.52% 🍏
here-naksha-lib-core NakshaVersion.java 42.31% 🍏

@rlakde rlakde merged commit 968820e into v2 Jan 16, 2025
3 checks passed
@rlakde rlakde deleted the v2_CASL_592-Extension_Cleanup_Capability branch January 22, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants