Fix #13: Remove unnecessary close call. #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The close in the source is not needed since calling call.cancel() will internally close the source.
|
Nudge. |
|
Is this ready to merge? |
|
A review is needed before merging. I requested it, hopefully soon |
ugurozmen
approved these changes
Apr 3, 2018
|
I started seeing OkHttp warnings about leaking response bodies again after this change |
|
Tracking some regression warnings in issue #17 |
|
I'll take a look tomorrow or on the weekend. I'll do some more proper testing on Android. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The close in the source is not needed since calling call.cancel()
will internally close the source.