Feature writer optimizations #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
roegi
commented
Jan 24, 2025
•
roegi
commented
- Enhance write_features() interface to improve performance by unwrapping function calls
- Improve CopySpace step performance by using inputType = 'Features' for the write_features() call
- Improve ImportFilesToSpace step performance by using inputType = 'Features' for the write_features() call
- Improve transport.import_from_s3_trigger_for_non_empty_layer() function performance by using proper input types for the write_features() call
qGYdXbY2
approved these changes
Jan 27, 2025
…ng function calls Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
…or the write_features() call - Improve ImportFilesToSpace step performance by using inputType = 'Features' for the write_features() call - Improve transport.import_from_s3_trigger_for_non_empty_layer() function performance by using proper input types for the write_features() call Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
- Fix CopySpace#buildCopySpaceQuery(); Add missing jsonb_agg() and use the correct input type Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
…_layer() Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
roegi
force-pushed
the
featureWriterOptimizations
branch
from
4ec1b5b to
c062de9
Compare
mchrza
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.