Move default PATH setting from CMake to get_rocksdb_files.sh (faceboo…

…k#1312)

Summary:
In c3f1703, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation.

The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself.

Pull Request resolved: facebook#1312

Differential Revision: D46285384

storage/rocksdb/CMakeLists.txt

@@ -52,7 +52,7 @@ ELSE()
   # get a list of rocksdb library source files
   # run with env -i to avoid passing variables
   EXECUTE_PROCESS(
-    COMMAND env -i CXX=${CMAKE_CXX_COMPILER} PATH="/sbin:/usr/sbin:/bin:/usr/bin"
+    COMMAND env -i CXX=${CMAKE_CXX_COMPILER}
     ${CMAKE_SOURCE_DIR}/storage/rocksdb/get_rocksdb_files.sh ${ROCKSDB_FOLLY}
     OUTPUT_VARIABLE SCRIPT_OUTPUT
     WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}

storage/rocksdb/get_rocksdb_files.sh

@@ -1,4 +1,8 @@
 #!/bin/bash
+if [ -z "$PATH" ]; then
+    export PATH="/sbin:/usr/sbin:/bin:/usr/bin"
+fi
+
 MKFILE=`mktemp`
 # create and run a simple makefile
 # include rocksdb make file relative to the path of this script