using of the asm feature to improve the performance of basic functions #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stlankes
commented
Nov 21, 2020
•
stlankes
commented
- PR uses Use REP MOVSQ/STOSQ on x86_64 rust-lang/compiler-builtins#365 to improve the performance
- fix broken CI and build the bootloader on windows correctly
in principle the PR uses rust-lang/compiler-builtins#365 to improve the performance
The makefile shouldn't be executed with powershell, since it doesn't work.
jschwe
suggested changes
Nov 21, 2020
There was a problem hiding this comment.
According to the documentation you should use the following command with powershell:
echo "mypath" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 21, 2020
78: using of the asm feature to improve the performance of basic functions r=jbreitbart a=stlankes - PR uses rust-lang/compiler-builtins#365 to improve the performance - fix broken CI and build the bootloader on windows correctly Co-authored-by: Stefan Lankes <slankes@eonerc.rwth-aachen.de>
jbreitbart
approved these changes
Nov 21, 2020
|
Build failed: |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Nov 21, 2020
78: using of the asm feature to improve the performance of basic functions r=jbreitbart a=stlankes - PR uses rust-lang/compiler-builtins#365 to improve the performance - fix broken CI and build the bootloader on windows correctly Co-authored-by: Stefan Lankes <slankes@eonerc.rwth-aachen.de>
|
Build failed: |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Nov 21, 2020
78: using of the asm feature to improve the performance of basic functions r=jbreitbart a=stlankes - PR uses rust-lang/compiler-builtins#365 to improve the performance - fix broken CI and build the bootloader on windows correctly Co-authored-by: Stefan Lankes <slankes@eonerc.rwth-aachen.de>
|
Build failed:
|
|
bors retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.