using compiler builtins to realize basic operations (e.g. memcpy) #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I enable the nightly tests because rust-lang/rust#77610 is merged to the nightly compiler. |
|
bors try |
jbreitbart
reviewed
Oct 27, 2020
There was a problem hiding this comment.
The file changes themselves look fine, but I am wondering if / how this changes the performance. Have you measured it?
According to rust-lang/compiler-builtins#339 the builtins are not (yet?) optimized, however there was a PR already merged for x86_64.
|
Do I promise better performance? :-) This is at least better than my implementation. I am separating the operations between user- and kernel space. This will be the next PR in RustyHermit and is more critical for the performance. |
|
bors r+ |
|
@jbreitbart Maybe rust-lang/compiler-builtins#365 is interesting for you. I try to support it in the next pull request. |
simonschoening
pushed a commit
to simonschoening/libhermit-rs
that referenced
this pull request
Aug 26, 2021
115: using compiler builtins to realize basic operations (e.g. memcpy) r=stlankes a=stlankes Co-authored-by: Stefan Lankes <slankes@eonerc.rwth-aachen.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.