add basic DNS support #1211
Merged
add basic DNS support #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stlankes
commented
May 20, 2024
stlankes
commented
- add functions to create DNS request
stlankes
force-pushed
the
dns
branch
2 times, most recently
from
dda4731 to
538c7a0
Compare
stlankes
force-pushed
the
dns
branch
4 times, most recently
from
6e52f12 to
a9a2f96
Compare
jounathaen
reviewed
May 22, 2024
jounathaen
reviewed
May 22, 2024
jounathaen
reviewed
May 22, 2024
jounathaen
reviewed
May 22, 2024
src/syscalls/socket.rs
Outdated
| }; | ||
|
|
||
| let name = unsafe { core::ffi::CStr::from_ptr(name) }; | ||
| let name = name.to_str().expect("Bad encoding").to_owned(); |
There was a problem hiding this comment.
Not sure, if returning an error in case of an error is the better approach. I can imagine a scenario, where this can be abused by user input to crash the application.
jounathaen
reviewed
May 22, 2024
jounathaen
reviewed
May 22, 2024
| /// }; | ||
| /// | ||
| /// // retake pointer to free memory | ||
| /// let _ = CString::from_raw(name); |
There was a problem hiding this comment.
Suggested change
| /// let _ = CString::from_raw(name); | |
| /// drop(name); | |
| /// println!("IP addr is {}", inaddr); |
a missing feature is a miss-configuration => it is an error
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.