Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming of env.rs to runtime_params.rs #1292

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Renaming of env.rs to runtime_params.rs #1292

wants to merge 5 commits into from
+67 −63

Conversation

jounathaen
Copy link
Member

And some minor related non-functional code improvements

fixes: #1291

mkroening
mkroening requested changes Jun 24, 2024
View reviewed changes
Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm opposed to this change as explained in #1291, but let's talk about this in person.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkroening mkroening mkroening requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename env.rs to args.rs or cli.rs.
2 participants
@jounathaen @mkroening