Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comments): fix repo links in TODOs #872

Merged
merged 2 commits into from
Aug 29, 2023
Merged

fix(comments): fix repo links in TODOs #872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a73a1ce
chore(xtask): remove resolved TODO
mkroening Aug 29, 2023
b02312c
fix(comments): fix repo links in TODOs
mkroening Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/arch/aarch64/mm/paging.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,7 @@ where
/// Returns the next subtable for the given page in the page table hierarchy.
///
/// Must only be called if a page of this size is mapped in a subtable!
// FIXME: https://github.com/hermitcore/hermit-kernel/issues/771
// FIXME: https://github.com/hermitcore/kernel/issues/771
#[allow(clippy::mut_from_ref)]
fn subtable<S: PageSize>(&self, page: Page<S>) -> &mut PageTable<L::SubtableLevel> {
assert!(L::LEVEL < S::MAP_LEVEL);
Expand Down
2 changes: 1 addition & 1 deletion src/macros.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ macro_rules! kernel_function {
}

// TODO: Properly switch kernel stack with newlib
// https://github.com/hermitcore/hermit-kernel/issues/471
// https://github.com/hermitcore/kernel/issues/471
#[cfg(all(target_arch = "x86_64", feature = "newlib"))]
macro_rules! kernel_function {
($f:ident($($x:tt)*)) => {{
Expand Down
6 changes: 2 additions & 4 deletions xtask/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ impl flags::Build {
.unwrap_or_default();

// TODO: Re-enable mutable-noalias
// https://github.com/hermitcore/hermit-kernel/issues/200
// https://github.com/hermitcore/kernel/issues/200
rustflags.push("-Zmutable-noalias=no");

if self.instrument_mcount {
Expand Down Expand Up @@ -197,8 +197,6 @@ impl flags::Clippy {
fn run(self) -> Result<()> {
let sh = sh()?;

// TODO: Enable clippy for aarch64
// https://github.com/hermitcore/hermit-kernel/issues/381
for target in [Arch::X86_64, Arch::AArch64] {
let target_args = target.cargo_args();
cmd!(sh, "cargo clippy {target_args...}").run()?;
Expand All @@ -210,7 +208,7 @@ impl flags::Clippy {
.arg("--features=acpi,fsgsbase,pci,smp,vga")
.run()?;
// TODO: Enable clippy for newlib
// https://github.com/hermitcore/hermit-kernel/issues/470
// https://github.com/hermitcore/kernel/issues/470
// cmd!(sh, "cargo clippy {target_args...}")
// .arg("--no-default-features")
// .arg("--features=acpi,fsgsbase,newlib,smp,vga")
Expand Down