Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(net): deallocate network buffers #943

Merged
merged 2 commits into from
Oct 7, 2023

Conversation

mkroening
Copy link
Member

Previously, network buffers were never deallocated again, resulting in quick out-of-memory situations if many connections are created.

Closes #899

Copy link
Contributor

@stlankes stlankes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A stupid failure from my side. :-(

@stlankes stlankes added this pull request to the merge queue Oct 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 6, 2023
@mkroening mkroening assigned mkroening and unassigned stlankes Oct 7, 2023
Signed-off-by: Martin Kröning <martin.kroening@eonerc.rwth-aachen.de>
@mkroening mkroening enabled auto-merge October 7, 2023 18:07
@mkroening mkroening added this pull request to the merge queue Oct 7, 2023
Merged via the queue into hermit-os:main with commit 1a926d7 Oct 7, 2023
@mkroening mkroening deleted the net-buf-leak branch October 7, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak: network buffers are never deallocated
2 participants