Skip to content

Commit

Permalink
nit(cli): move file_mapping further up in Args
Browse files Browse the repository at this point in the history
It makes sense to group it togehter with output and stats, instead of
pushing it all the way down beneath the Memory and Cpu help headings.
We presume that the settings under those headings to be more "optional"
than --file-mapping, as the defaults do not have to be changed very
often.
  • Loading branch information
n0toose authored and jounathaen committed Jan 9, 2025
1 parent 92f11ef commit aa41cdd
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions src/bin/uhyve.rs
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,14 @@ struct Args {
#[clap(long)]
stats: bool,

/// Paths that the kernel should be able to view, read or write.
///
/// Desired paths must be explicitly defined after a colon.
///
/// Example: --file-mapping host_dir:guest_dir --file-mapping file.txt:guest_file.txt
#[clap(long)]
file_mapping: Vec<String>,

#[clap(flatten, next_help_heading = "Memory OPTIONS")]
memory_args: MemoryArgs,

Expand All @@ -61,14 +69,6 @@ struct Args {
#[cfg(target_os = "linux")]
gdb_port: Option<u16>,

/// Paths that the kernel should be able to view, read or write.
///
/// Desired paths must be explicitly defined after a colon.
///
/// Example: --file-mapping host_dir:guest_dir --file-mapping file.txt:guest_file.txt
#[clap(long)]
file_mapping: Vec<String>,

/// The kernel to execute
#[clap(value_parser)]
kernel: PathBuf,
Expand Down

0 comments on commit aa41cdd

Please sign in to comment.