Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit(hypercall): remove unnecessary .as_bytes() call #813

Merged
merged 2 commits into from
Dec 1, 2024

Conversation

n0toose
Copy link
Member

@n0toose n0toose commented Nov 28, 2024

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.55%. Comparing base (f6fe3df) to head (73f3d15).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/hypercall.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #813   +/-   ##
=======================================
  Coverage   71.55%   71.55%           
=======================================
  Files          21       21           
  Lines        3041     3041           
=======================================
  Hits         2176     2176           
  Misses        865      865           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jounathaen
Copy link
Member

Thanks!

@jounathaen jounathaen force-pushed the nit-hypercall-as-bytes branch from b9d06e5 to f1a8acb Compare December 1, 2024 18:16
@jounathaen jounathaen enabled auto-merge December 1, 2024 18:16
@jounathaen jounathaen added this pull request to the merge queue Dec 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 1, 2024
@jounathaen jounathaen enabled auto-merge December 1, 2024 18:25
@jounathaen jounathaen added this pull request to the merge queue Dec 1, 2024
Merged via the queue into hermit-os:main with commit cb1371f Dec 1, 2024
11 checks passed
@jounathaen jounathaen deleted the nit-hypercall-as-bytes branch December 1, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants