feat(isolation): improve canonicalization of host paths #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This turns host paths that do not exist yet into absolute paths. Doing something similar for the guest paths is also a TODO.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #819 +/- ##
==========================================
+ Coverage 71.51% 71.55% +0.03%
==========================================
Files 21 21
Lines 3037 3041 +4
==========================================
+ Hits 2172 2176 +4
Misses 865 865 ☔ View full report in Codecov by Sentry. |
|
👍 |
|
i think that those were enough notifications from me for today, enjoy the rest of your sunday! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns host paths that do not exist yet into absolute paths. Doing something similar for the guest paths is also a TODO.