Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fleet Manager Go interface #141

Merged
merged 5 commits into from
Mar 15, 2024
Merged

Add Fleet Manager Go interface #141

merged 5 commits into from
Mar 15, 2024

Conversation

sesposito
Copy link
Member

No description provided.

@sesposito sesposito mentioned this pull request Mar 4, 2024
Merged
zyro
zyro requested changes Mar 6, 2024
View reviewed changes
Copy link
Member

@zyro zyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, plus how do we feel about JSON tags being camelCase rather than snake_case? We typically use snake_case everywhere else I think.

runtime/runtime.go Outdated Show resolved Hide resolved
@sesposito sesposito merged commit 7ab0877 into master Mar 15, 2024
2 checks passed
@sesposito sesposito deleted the spe-nakama-fleet-manager branch March 15, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyro zyro zyro approved these changes

Assignees

@zyro zyro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sesposito @zyro