Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize generated gRPC client #4

Closed
2 tasks done
obrunsmann opened this issue Jun 3, 2021 · 7 comments
Closed
2 tasks done

Organize generated gRPC client #4

obrunsmann opened this issue Jun 3, 2021 · 7 comments
Assignees
Milestone

Comments

@obrunsmann
Copy link
Contributor

obrunsmann commented Jun 3, 2021

  • Publish model files from the library → No imports of the .pb.dart files should be necessary from outside the package
  • Remove unused generated files (some unit test files have been generated as well from google/protobuf package)
@obrunsmann obrunsmann added this to the v1.0.0 milestone Jun 3, 2021
@obrunsmann obrunsmann self-assigned this Jun 3, 2021
@Allan-Nava
Copy link

How can you handle the grpc stuff ?

@obrunsmann
Copy link
Contributor Author

What do you mean?

@Allan-Nava
Copy link

What do you mean?

Like this for nakama swift https://github.com/Allan-Nava/nakama-swift/tree/master/proto

@obrunsmann
Copy link
Contributor Author

Hmm unfortunately I haven't quite figured out what you mean yet. This issue is about removing the files that are currently generated but not needed.

Is just clean up - not very critical :)

@Allan-Nava
Copy link

Hmm unfortunately I haven't quite figured out what you mean yet. This issue is about removing the files that are currently generated but not needed.

Is just clean up - not very critical :)

Ah ok, because in swift we generated automatically the swift files from proto

@obrunsmann
Copy link
Contributor Author

obrunsmann commented Jun 3, 2021

Yeah right, doing same here (https://github.com/obrunsmann/flutter_nakama/blob/main/lib/api/generate.sh). But the problem I would like to solve is to organize the mass of generated API Docs for all the compiled pb stuff like here: https://pub.dev/documentation/nakama/latest

So the first thing might be to disable generation of unused pb files and the second thing might be to check if the files could get some namespaceing so that this flutter library not expose so many classes

@Allan-Nava
Copy link

Yeah right, doing same here (https://github.com/obrunsmann/flutter_nakama/blob/main/lib/api/generate.sh). But the problem I would like to solve is to organize the mass of generated API Docs for all the compiled pb stuff like here: https://pub.dev/documentation/nakama/latest

So the first thing might be to disable generation of unused pb files and the second thing might be to check if the files could get some namespaceing so that this flutter library not expose so many classes

Ok as you wish

obrunsmann added a commit that referenced this issue Jul 25, 2021
Cleanup compile script, remove unused code and move compile script into tools folder

closed #15
closed #4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants