Fix match and party data message callbacks #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britzl
commented
Jun 13, 2024
| @@ -15,6 +15,13 @@ | |||
| if message.match_data then | |||
| message.match_data.data = b64.decode(message.match_data.data) | |||
| end | |||
| if message.cid then | |||
There was a problem hiding this comment.
Moved from defold.lua to the generated socket.lua
britzl
commented
Jun 13, 2024
codegen/realtime.py
Outdated
| @@ -260,10 +286,13 @@ def messages_to_lua(rtapi): | |||
| STATUS_MESSAGES = [ "StatusFollow", "StatusUnfollow", "StatusUpdate" ] | |||
| ALL_MESSAGES = CHANNEL_MESSAGES + MATCH_MESSAGES + MATCHMAKER_MESSAGES + PARTY_MESSAGES + STATUS_MESSAGES | |||
|
|
|||
| NO_CALLBACK_MESSAGES = [ "MatchDataSend", "PartyDataSend" ] | |||
There was a problem hiding this comment.
These two messages are the ones that seem to not set a cid in other client implementations (for instance nakama-dotnet)
lugehorsam
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The socket code expected all messages to return a response from the server when in fact match and party data messages are "fire and forget". This change makes sure that match data and party data message complete immediately when the message has been sent. The message callback handling has also been improved and moved from the engine specific code to the generic socket code.
Fixes #77