Fix NakamaSocket.add_matchmaker_party_async() and the tests for it #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @dsnopek I've passed it to Tom to review. You can assign future PRs directly to Tom. |
tomglenn
approved these changes
May 25, 2022
|
Thanks @dsnopek 👍 |
dsnopek
added a commit
to dsnopek/nakama-godot
that referenced
this pull request
May 31, 2022
tomglenn
pushed a commit
that referenced
this pull request
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue in
NakamaSocket.add_matchmaker_party_async()that went unnoticed, in part, because of an issue in the tests for it. This also fixes the tests!I discovered this while working on the Godot 4 port on PR #103.