Support purchases-not-null-uid.sql migration crdb. #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix purchases-not-null-uid.sql migration up for crdb. The migration failed because pg and crdb name fk constraints differently. Set the migration as notransaction because crdb fails to apply it if multiple alter table statements are made on the same fk within the same transaction.
zyro
approved these changes
Mar 21, 2023
deflinhec
added a commit
to deflinhec/nakama
that referenced
this pull request
Mar 30, 2023
* master: (27 commits) Satori API integration fixes (heroiclabs#1005) Attempt to exchange Google's authorization code when given one instead of as a JWT (heroiclabs#997) manually revert protobufany and updategroup in swagger.json (heroiclabs#1003) Make haystack cursors consistent with listing (heroiclabs#994) Support purchases-not-null-uid.sql migration on crdb. (heroiclabs#992) Add runtimes satori integration (heroiclabs#993) Disconnect banned users (heroiclabs#1001) Add runtime http insecure flag (heroiclabs#1002) Add Go runtime GroupUpdate userID param (heroiclabs#996) Better handling of matchmaker operations while the interval process is running. Ensure direct message channel message listing is correctly scoped to participants only. Update get purchase/subscription signature (heroiclabs#990) Fix reversal of open/closed group listing filter (heroiclabs#989) Always log out a deleted user (heroiclabs#987) Listing returned vars (heroiclabs#986) Add tournament record delete runtime functions. (heroiclabs#977) Improve google refund polling handling. (heroiclabs#982) Console user and authentication improvements. (heroiclabs#978) Console session handling improvements. (heroiclabs#979) Fix google purchase upsert query. (heroiclabs#973) ... # Conflicts: # console/ui/dist/prod-nt/index.html # console/ui/dist/prod/index.html
deflinhec
added a commit
to deflinhec/nakama
that referenced
this pull request
Mar 30, 2023
* master: (27 commits) Satori API integration fixes (heroiclabs#1005) Attempt to exchange Google's authorization code when given one instead of as a JWT (heroiclabs#997) manually revert protobufany and updategroup in swagger.json (heroiclabs#1003) Make haystack cursors consistent with listing (heroiclabs#994) Support purchases-not-null-uid.sql migration on crdb. (heroiclabs#992) Add runtimes satori integration (heroiclabs#993) Disconnect banned users (heroiclabs#1001) Add runtime http insecure flag (heroiclabs#1002) Add Go runtime GroupUpdate userID param (heroiclabs#996) Better handling of matchmaker operations while the interval process is running. Ensure direct message channel message listing is correctly scoped to participants only. Update get purchase/subscription signature (heroiclabs#990) Fix reversal of open/closed group listing filter (heroiclabs#989) Always log out a deleted user (heroiclabs#987) Listing returned vars (heroiclabs#986) Add tournament record delete runtime functions. (heroiclabs#977) Improve google refund polling handling. (heroiclabs#982) Console user and authentication improvements. (heroiclabs#978) Console session handling improvements. (heroiclabs#979) Fix google purchase upsert query. (heroiclabs#973) ... # Conflicts: # console/ui/dist/prod-nt/index.html # console/ui/dist/prod/index.html
deflinhec
added a commit
to deflinhec/nakama
that referenced
this pull request
Mar 30, 2023
* master: (27 commits) Satori API integration fixes (heroiclabs#1005) Attempt to exchange Google's authorization code when given one instead of as a JWT (heroiclabs#997) manually revert protobufany and updategroup in swagger.json (heroiclabs#1003) Make haystack cursors consistent with listing (heroiclabs#994) Support purchases-not-null-uid.sql migration on crdb. (heroiclabs#992) Add runtimes satori integration (heroiclabs#993) Disconnect banned users (heroiclabs#1001) Add runtime http insecure flag (heroiclabs#1002) Add Go runtime GroupUpdate userID param (heroiclabs#996) Better handling of matchmaker operations while the interval process is running. Ensure direct message channel message listing is correctly scoped to participants only. Update get purchase/subscription signature (heroiclabs#990) Fix reversal of open/closed group listing filter (heroiclabs#989) Always log out a deleted user (heroiclabs#987) Listing returned vars (heroiclabs#986) Add tournament record delete runtime functions. (heroiclabs#977) Improve google refund polling handling. (heroiclabs#982) Console user and authentication improvements. (heroiclabs#978) Console session handling improvements. (heroiclabs#979) Fix google purchase upsert query. (heroiclabs#973) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix purchases-not-null-uid.sql migration for crdb.
Address fk inconsistent naming across pg and crdb.
Split the migration in two files so that the alter statements are executed in two separate transactions (crdb fails to migrate if multiple alter table statements are made within the same transaction).
See https://stackoverflow.com/questions/68803747/encapsulating-a-drop-and-add-constraint-in-a-transaction.