Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use check_changelog workflow from heroku-buildpack-ruby #43

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Jul 23, 2024

This PR changes the check_changelog workflow to match one in heroku-buildpack-ruby.

@olleolleolle olleolleolle requested a review from a team as a code owner July 23, 2024 13:57
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! Looking at the rest of this workflow, I see it's a bit out of date compared to the workflow we use in some of our other repositories. Would you mind syncing the file here with this one?
https://github.com/heroku/heroku-buildpack-ruby/blob/main/.github/workflows/check_changelog.yml

@olleolleolle
Copy link
Contributor Author

Thank you for the PR! Looking at the rest of this workflow, I see it's a bit out of date compared to the workflow we use in some of our other repositories. Would you mind syncing the file here with this one? https://github.com/heroku/heroku-buildpack-ruby/blob/main/.github/workflows/check_changelog.yml

@edmorley Done!

@olleolleolle olleolleolle changed the title CI: Use actions/checkout@v4 [changelog skip] CI: Use check_changelog workflow from heroku-buildpack-ruby [changelog skip] Jul 23, 2024
@edmorley edmorley added the skip changelog Skip the check-changelog check label Jul 23, 2024
@edmorley edmorley changed the title CI: Use check_changelog workflow from heroku-buildpack-ruby [changelog skip] CI: Use check_changelog workflow from heroku-buildpack-ruby Jul 23, 2024
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@edmorley edmorley merged commit 8db8c09 into heroku:main Jul 23, 2024
2 of 3 checks passed
@olleolleolle olleolleolle deleted the patch-1 branch July 23, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog Skip the check-changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants