Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create multi-arch manifest copy, rather than retagging. #252

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

joshwlewis
Copy link
Member

@joshwlewis joshwlewis commented Mar 4, 2024

docker tag SOURCE TARGET isn't aware of multi-arch image manifests. docker tag therefore isn't a copy of a manifest, but a new single-arch image. This leads to CI publishing single-arch images instead of multi-arch as noted here: #245 (comment).

For multi-arch images / manifest lists, we should instead use docker buildx imagetools create, so the manifest list is preserved.

@joshwlewis joshwlewis requested a review from a team as a code owner March 4, 2024 16:48
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :-)

@joshwlewis joshwlewis merged commit 80cb879 into main Mar 4, 2024
4 checks passed
@joshwlewis joshwlewis deleted the retag-multi-arch branch March 4, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants