Switch away from deprecated path-based S3 URLs (#278)

S3 URLs where the bucket name is part of the URL path are deprecated. Instead, it's recommended to use the virtual-hosted style references, where the bucket name is part of the domain. The latter allows AWS to use DNS to direct requests directly to the appropriate region's S3 endpoint, rather than having to route via the global S3 endpoint (which AWS describe as being a single point of failure/harder to scale etc). There is a small chance this may also help with some of the S3 reliability issues seen in `heroku/builder` Circle CI runs - however even if it doesn't, at least we'll no longer be using the deprecated URLs/endpoints. See: https://aws.amazon.com/blogs/aws/amazon-s3-path-deprecation-plan-the-rest-of-the-story/ https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html https://docs.aws.amazon.com/general/latest/gr/s3.html#s3_region GUS-W-11283397.
heroku · Jun 13, 2022 · 7454fbe · 7454fbe
1 parent b9dc5ad
commit 7454fbe
Show file tree

Hide file tree

Showing 4 changed files with 1,262 additions and 1,256 deletions.
diff --git a/buildpacks/nodejs-engine/CHANGELOG.md b/buildpacks/nodejs-engine/CHANGELOG.md
@@ -4,16 +4,20 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+- Switch away from deprecated path-based S3 URLs
+
 ## [0.8.5] 2022/06/08
 
 - Added node version 16.15.1, 18.3.0, 17.9.1.
+
 ## [0.8.4] 2022/05/23
 
 - Added node version 14.19.3, 18.2.0.
 - Added node version 14.19.2, 18.1.0, 16.15.0.
 - Added node version 18.0.0.
 - Added node version 17.9.0.
 - Added node version 12.22.12.
+
 ## [0.8.3] 2022/04/05
 
 - Add support for the heroku-22 stack