Fix compilation of buildpack on ARM64 #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it wasn't possible to compile the Rust parts of the
buildpack on ARM64 (such as when using an M1 Macbook),
since the compile failed with:
```
error[E0425]: cannot find value `ARCH` in this scope
--> common/nodejs-utils/src/inv.rs:45:45
|
45 | let platform = format!("{}-{}", OS, ARCH);
| ^^^^ not found in this scope
|
help: consider importing this constant
|
1 | use std::env::consts::ARCH;
|
```
This makes contributing to the buildpack from an M1 machine
frustrating, since one has to comment out the architecture
conditional every time, then remember not to include it in
the commit with the other changes.
At such time as the Node.js buildpack fully supports ARM64
Docker images, conditionals can be added back with the
appropriate platform values.
GUS-W-11817789.
joshwlewis
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it wasn't possible to compile the Rust parts of the buildpack on ARM64 (such as when using an M1 Macbook), since the compile failed with:
This makes contributing to the buildpack from an M1 machine frustrating, since one has to comment out the architecture conditional every time, then remember not to include it in the commit with the other changes.
At such time as the Node.js buildpack fully supports ARM64 Docker images, conditionals can be added back with the appropriate platform values.
Fixes #310.
GUS-W-11817789.