Add otel tracing via file exports to nodejs-corepack #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colincasey
reviewed
Sep 22, 2023
colincasey
reviewed
Sep 22, 2023
colincasey
reviewed
Sep 22, 2023
There was a problem hiding this comment.
seems fairly straightforward.
also interesting is the opentelemetry crate allows you to get a reference to the active span from anywhere.
colincasey
approved these changes
Sep 25, 2023
This was referenced Sep 25, 2023
Merged
heroku-linguist bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Sep 25, 2023
## heroku/nodejs - Updated `heroku/nodejs-corepack` to `1.1.6`. - Updated `heroku/nodejs-engine` to `1.1.6`. - Updated `heroku/nodejs-npm` to `1.1.6`. - Updated `heroku/nodejs-pnpm-install` to `1.1.6`. - Updated `heroku/nodejs-yarn` to `1.1.6`. ## heroku/nodejs-corepack - Add basic OpenTelemetry tracing. ([#652](heroku/buildpacks-nodejs#652)) ## heroku/nodejs-engine - No changes. ## heroku/nodejs-function - Updated `heroku/nodejs-engine` to `1.1.6`. - Updated `heroku/nodejs-function-invoker` to `1.1.6`. - Updated `heroku/nodejs-npm` to `1.1.6`. ## heroku/nodejs-function-invoker - No changes. ## heroku/nodejs-npm - No changes. ## heroku/nodejs-pnpm-install - No changes. ## heroku/nodejs-yarn - No changes. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
colincasey
pushed a commit
that referenced
this pull request
Oct 4, 2023
## heroku/nodejs - Updated `heroku/nodejs-corepack` to `1.1.6`. - Updated `heroku/nodejs-engine` to `1.1.6`. - Updated `heroku/nodejs-npm` to `1.1.6`. - Updated `heroku/nodejs-pnpm-install` to `1.1.6`. - Updated `heroku/nodejs-yarn` to `1.1.6`. ## heroku/nodejs-corepack - Add basic OpenTelemetry tracing. ([#652](#652)) ## heroku/nodejs-engine - No changes. ## heroku/nodejs-function - Updated `heroku/nodejs-engine` to `1.1.6`. - Updated `heroku/nodejs-function-invoker` to `1.1.6`. - Updated `heroku/nodejs-npm` to `1.1.6`. ## heroku/nodejs-function-invoker - No changes. ## heroku/nodejs-npm - No changes. ## heroku/nodejs-pnpm-install - No changes. ## heroku/nodejs-yarn - No changes. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
colincasey
added a commit
that referenced
this pull request
Oct 28, 2024
Removes the otel tracing added in [#652](#652) which was introduced before the `libcnb` tracing support in [heroku/libcnb.rs#723](heroku/libcnb.rs#723). This is also blocking the dependency updates in [#942](#942).
colincasey
added a commit
that referenced
this pull request
Nov 5, 2024
Removes the otel tracing added in [#652](#652) in favor of the `libcnb` tracing support added in [heroku/libcnb.rs#723](heroku/libcnb.rs#723).
colincasey
added a commit
that referenced
this pull request
Nov 6, 2024
* Use the tracing features provided by `libcnb` Removes the otel tracing added in [#652](#652) in favor of the `libcnb` tracing support added in [heroku/libcnb.rs#723](heroku/libcnb.rs#723). * Update CHANGELOG.md * Update buildpacks/nodejs-corepack/CHANGELOG.md Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com> --------- Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an
initTracerfunction for Node.js buildpacks to use, which sets up an OpenTelemetry file exporter for tracing data.Additionally, this adds some tracing to the
heroku/nodejs-corepackbuildpack.