Prepare integration tests to run under a single builder #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the double tests that were added in several integration suites that would explicitly run against the `20` and `22` stacks and updates the CI workflow to control this.
Removes the double tests that were added in several integration suites that would explicitly run against the `20` and `22` stacks and updates the CI workflow to control this.
|
TODO: switch the CI validations from |
joshwlewis
approved these changes
Sep 29, 2023
colincasey
added a commit
that referenced
this pull request
Oct 4, 2023
* main: (48 commits) Remove cutlass job from CI (#675) Update Inventory for heroku/nodejs-npm-engine (#624) Remove cutlass integration tests (#674) Update Inventory for heroku/nodejs-engine (#671) Update Inventory for heroku/nodejs-yarn (#670) Prepare integration tests to run under a single builder (#663) Bump Swatinem/rust-cache from 2.6.2 to 2.7.0 (#665) Bump actions/checkout from 3 to 4 (#664) Bump regex from 1.9.5 to 1.9.6 (#666) Bump thiserror from 1.0.48 to 1.0.49 (#667) Bump ureq from 2.7.1 to 2.8.0 (#668) Bump serde_json from 1.0.105 to 1.0.107 (#669) Fix CNB builder repo URL (#672) Fix non-existent builder Docker image name (#673) Updates `libcnb` to 0.15.0 (#662) Switch tests from `heroku/buildpacks:20` to `heroku/builder:20` (#660) Prepare release v1.1.6 (#658) Bump regex from 1.9.4 to 1.9.5 (#656) Bump indoc from 2.0.3 to 2.0.4 (#657) Bump toml from 0.7.6 to 0.7.8 (#654) ... # Conflicts: # buildpacks/nodejs-engine/CHANGELOG.md
colincasey
added a commit
that referenced
this pull request
Oct 4, 2023
* main: (31 commits) Add `npm` to `nodejs-engine` build plan (#622) Remove cutlass job from CI (#675) Update Inventory for heroku/nodejs-npm-engine (#624) Remove cutlass integration tests (#674) Update Inventory for heroku/nodejs-engine (#671) Update Inventory for heroku/nodejs-yarn (#670) Prepare integration tests to run under a single builder (#663) Bump Swatinem/rust-cache from 2.6.2 to 2.7.0 (#665) Bump actions/checkout from 3 to 4 (#664) Bump regex from 1.9.5 to 1.9.6 (#666) Bump thiserror from 1.0.48 to 1.0.49 (#667) Bump ureq from 2.7.1 to 2.8.0 (#668) Bump serde_json from 1.0.105 to 1.0.107 (#669) Fix CNB builder repo URL (#672) Fix non-existent builder Docker image name (#673) Updates `libcnb` to 0.15.0 (#662) Switch tests from `heroku/buildpacks:20` to `heroku/builder:20` (#660) Prepare release v1.1.6 (#658) Bump regex from 1.9.4 to 1.9.5 (#656) Bump indoc from 2.0.3 to 2.0.4 (#657) ... # Conflicts: # Cargo.lock # Cargo.toml # buildpacks/nodejs-npm-engine/CHANGELOG.md # test_support/Cargo.toml # test_support/src/lib.rs
colincasey
added a commit
that referenced
this pull request
Oct 4, 2023
* main: (31 commits) Add `npm` to `nodejs-engine` build plan (#622) Remove cutlass job from CI (#675) Update Inventory for heroku/nodejs-npm-engine (#624) Remove cutlass integration tests (#674) Update Inventory for heroku/nodejs-engine (#671) Update Inventory for heroku/nodejs-yarn (#670) Prepare integration tests to run under a single builder (#663) Bump Swatinem/rust-cache from 2.6.2 to 2.7.0 (#665) Bump actions/checkout from 3 to 4 (#664) Bump regex from 1.9.5 to 1.9.6 (#666) Bump thiserror from 1.0.48 to 1.0.49 (#667) Bump ureq from 2.7.1 to 2.8.0 (#668) Bump serde_json from 1.0.105 to 1.0.107 (#669) Fix CNB builder repo URL (#672) Fix non-existent builder Docker image name (#673) Updates `libcnb` to 0.15.0 (#662) Switch tests from `heroku/buildpacks:20` to `heroku/builder:20` (#660) Prepare release v1.1.6 (#658) Bump regex from 1.9.4 to 1.9.5 (#656) Bump indoc from 2.0.3 to 2.0.4 (#657) ... # Conflicts: # Cargo.lock # Cargo.toml # meta-buildpacks/nodejs/buildpack.toml # test_support/Cargo.toml # test_support/src/lib.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the double tests that were added in several integration suites that would explicitly run against the
20and22stacks and updates the CI workflow to control this.This also leverages
libcnb@0.15.0to run our integration tests against the composite buildpacks (heroku/nodejsandheroku/nodejs-function) so the build order/grouping matches what the user would see instead of manually defining individual buildpacks in tests.