Remove check and warning for node_modules directory
#998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This warning was carried over from the classic Heroku Node.js buildpack which did support both `npm install` and `npm ci`. If a `node_modules` directory existed and there was no lockfile present, this could cause issues with the dependencies installed. This buildpack only supports `npm ci` so this check and warning is not required. If the `node_modules` directory is already present, `npm ci` will automatically remove it.
edmorley
approved these changes
Jan 9, 2025
heroku-linguist bot
added a commit
that referenced
this pull request
Jan 10, 2025
## heroku/nodejs ### Changed - Updated `heroku/nodejs-corepack` to `3.4.3`. - Updated `heroku/nodejs-engine` to `3.4.3`. - Updated `heroku/nodejs-npm-engine` to `3.4.3`. - Updated `heroku/nodejs-npm-install` to `3.4.3`. - Updated `heroku/nodejs-pnpm-engine` to `3.4.3`. - Updated `heroku/nodejs-pnpm-install` to `3.4.3`. - Updated `heroku/nodejs-yarn` to `3.4.3`. ## heroku/nodejs-corepack - No changes. ## heroku/nodejs-engine - No changes. ## heroku/nodejs-function ### Changed - Updated `heroku/nodejs-engine` to `3.4.3`. - Updated `heroku/nodejs-function-invoker` to `3.4.3`. - Updated `heroku/nodejs-npm` to `3.4.3`. ## heroku/nodejs-function-invoker - No changes. ## heroku/nodejs-npm - No changes. ## heroku/nodejs-npm-engine - No changes. ## heroku/nodejs-npm-install ### Removed - Check and warning for `node_modules` directory is unnecessary since `npm ci` will remove it before installing dependencies. ([#998]#998)) ## heroku/nodejs-pnpm-engine - No changes. ## heroku/nodejs-pnpm-install - No changes. ## heroku/nodejs-yarn - No changes.
Merged
heroku-linguist bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Jan 10, 2025
## heroku/nodejs ### Changed - Updated `heroku/nodejs-corepack` to `3.4.3`. - Updated `heroku/nodejs-engine` to `3.4.3`. - Updated `heroku/nodejs-npm-engine` to `3.4.3`. - Updated `heroku/nodejs-npm-install` to `3.4.3`. - Updated `heroku/nodejs-pnpm-engine` to `3.4.3`. - Updated `heroku/nodejs-pnpm-install` to `3.4.3`. - Updated `heroku/nodejs-yarn` to `3.4.3`. ## heroku/nodejs-corepack - No changes. ## heroku/nodejs-engine - No changes. ## heroku/nodejs-function ### Changed - Updated `heroku/nodejs-engine` to `3.4.3`. - Updated `heroku/nodejs-function-invoker` to `3.4.3`. - Updated `heroku/nodejs-npm` to `3.4.3`. ## heroku/nodejs-function-invoker - No changes. ## heroku/nodejs-npm - No changes. ## heroku/nodejs-npm-engine - No changes. ## heroku/nodejs-npm-install ### Removed - Check and warning for `node_modules` directory is unnecessary since `npm ci` will remove it before installing dependencies. ([#998]heroku/buildpacks-nodejs#998)) ## heroku/nodejs-pnpm-engine - No changes. ## heroku/nodejs-pnpm-install - No changes. ## heroku/nodejs-yarn - No changes.
heroku-linguist bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Jan 10, 2025
## heroku/nodejs ### Changed - Updated `heroku/nodejs-corepack` to `3.4.3`. - Updated `heroku/nodejs-engine` to `3.4.3`. - Updated `heroku/nodejs-npm-engine` to `3.4.3`. - Updated `heroku/nodejs-npm-install` to `3.4.3`. - Updated `heroku/nodejs-pnpm-engine` to `3.4.3`. - Updated `heroku/nodejs-pnpm-install` to `3.4.3`. - Updated `heroku/nodejs-yarn` to `3.4.3`. ## heroku/nodejs-corepack - No changes. ## heroku/nodejs-engine - No changes. ## heroku/nodejs-function ### Changed - Updated `heroku/nodejs-engine` to `3.4.3`. - Updated `heroku/nodejs-function-invoker` to `3.4.3`. - Updated `heroku/nodejs-npm` to `3.4.3`. ## heroku/nodejs-function-invoker - No changes. ## heroku/nodejs-npm - No changes. ## heroku/nodejs-npm-engine - No changes. ## heroku/nodejs-npm-install ### Removed - Check and warning for `node_modules` directory is unnecessary since `npm ci` will remove it before installing dependencies. ([#998]heroku/buildpacks-nodejs#998)) ## heroku/nodejs-pnpm-engine - No changes. ## heroku/nodejs-pnpm-install - No changes. ## heroku/nodejs-yarn - No changes. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This warning was carried over from the classic Heroku Node.js buildpack which did support both
npm installandnpm ci. If anode_modulesdirectory existed and there was no lockfile present, this could cause issues with the dependencies installed.This buildpack only supports
npm ciso this check and warning is not required. If thenode_modulesdirectory is already present,npm ciwill automatically remove it.