Move fun_run to its own crate #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/rm-rf-fun_run
branch
from
4d5bf64
to
2fb195e
Compare
schneems
force-pushed
the
schneems/rm-rf-fun_run
branch
from
2fb195e
to
c13d88c
Compare
The `fun_run` library is small but it can stand on its own. I ported it to a crate as an exercise in code cleanup and to remove unnecessary dependencies.
schneems
force-pushed
the
schneems/rm-rf-fun_run
branch
from
c13d88c
to
64aa67c
Compare
edmorley
approved these changes
Nov 3, 2023
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
schneems
pushed a commit
to schneems/fun_run
that referenced
this pull request
Nov 6, 2023
In the migration of the Ruby buildpack to use this crate I noticed a regression:
```
- Running `bash -c "ps aux | grep cargo"`
rschneeman 26398 0.0 0.0 408417520 9600 s004 S+ 11:24AM 0:00.13 /Users/rschneeman/.cargo/bin/cargo-watch watch -c -x ltest
rschneeman 17561 0.0 0.0 408494848 848 s000 R+ 2:39PM 0:00.00 grep cargo
rschneeman 17559 0.0 0.0 408627920 3088 s000 S+ 2:39PM 0:00.00 bash -c ps aux | grep cargo
rschneeman 15128 0.0 0.0 408433904 10176 s006 S+ 2:35PM 0:00.40 /Users/rschneeman/.cargo/bin/cargo-watch watch -c -x ltest
- Done (< 0.1s)
```
I isolated it to the `fun_run` PR heroku/buildpacks-ruby#232 and after some debugging found it was due to accidentally copying `child.stdout` for `child_stderr`. I added a test that verifies that stderr is redirected correctly.
edmorley
added a commit
to heroku/buildpacks-nodejs
that referenced
this pull request
Nov 17, 2023
Since the feature branch no longer exists. This will fix Dependabot erroring out with: ``` Errored with the message "Dependabot couldn't fetch the branch/reference for commons" ``` This also required adding `fun_run` as an explicit dependency, due to: heroku/buildpacks-ruby#232
This was referenced Mar 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fun_runlibrary is small but it can stand on its own. I ported it to a crate as an exercise in code cleanup and to remove unnecessary dependencies.