Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update builder to heroku-24 on print getting started guide github action #290

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

lilacstella
Copy link
Contributor

@lilacstella lilacstella commented Jun 10, 2024

Heroku 24 is now a trusted and suggested builder in pack. However, now running pack build with heroku-22 now fails due to a bug that suggests the builder is not trusted even though it is configured to be.

Run pack build my-image --force-color --builder heroku/builder:22 --buildpack heroku/nodejs-engine --buildpack packaged/x86_64-unknown-linux-musl/debug/heroku_ruby --path tmp/ruby-getting-started --pull-policy never 
ERROR: failed to build: fetching lifecycle image: image buildpacksio/lifecycle:0.19.6 does not exist on the daemon: not found

We can update the version of the heroku builder that the github workflow for printing getting started is using in order for this action to pass.

dependabot bot and others added 2 commits June 5, 2024 20:46
Bumps [buildpacks/github-actions](https://github.com/buildpacks/github-actions) from 5.6.0 to 5.7.1.
- [Release notes](https://github.com/buildpacks/github-actions/releases)
- [Commits](buildpacks/github-actions@v5.6.0...v5.7.1)

---
updated-dependencies:
- dependency-name: buildpacks/github-actions
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@lilacstella lilacstella self-assigned this Jun 10, 2024
@lilacstella lilacstella requested a review from a team as a code owner June 10, 2024 15:28
@lilacstella lilacstella added github actions Pull requests that update Github Actions code skip changelog labels Jun 10, 2024
@edmorley edmorley requested review from schneems and removed request for a team June 10, 2024 16:30
@lilacstella lilacstella changed the base branch from dependabot/github_actions/buildpacks/github-actions-5.7.1 to main June 11, 2024 23:21
Copy link
Contributor

@schneems schneems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this up and running!

@schneems schneems merged commit 6fdc19e into main Jun 12, 2024
7 of 8 checks passed
@schneems schneems deleted the lilacstella/update-print-getting-started-heroku-24 branch June 12, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github actions Pull requests that update Github Actions code skip changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants