Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure process to complain about unset variable #307

Merged
merged 6 commits into from
Jul 31, 2024

Conversation

lilacstella
Copy link
Contributor

When using docker run, the default rails app configuration assumes the existence of a $PORT environmental variable but does not tell the user that it is required. By making the lack of a definition for the environmental variable, the user can understand how to run the application properly.

Resolves #306

@lilacstella lilacstella marked this pull request as ready for review July 19, 2024 22:39
@lilacstella lilacstella requested a review from a team as a code owner July 19, 2024 22:39
@lilacstella lilacstella removed the request for review from a team July 21, 2024 04:17
@lilacstella lilacstella force-pushed the lilacstella/hint-missing-param branch from 4e6ee55 to a2a5646 Compare July 21, 2024 04:40
@lilacstella lilacstella changed the title configure process to complain about unset variable Configure process to complain about unset variable Jul 22, 2024
@lilacstella lilacstella enabled auto-merge (squash) July 31, 2024 00:54
Copy link
Contributor

@schneems schneems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lilacstella lilacstella merged commit c41c5e7 into main Jul 31, 2024
7 checks passed
@lilacstella lilacstella deleted the lilacstella/hint-missing-param branch July 31, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hint missing values for docker run
2 participants