Update tutorials #83
Merged
Update tutorials #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![heroku-linguist[bot]](https://avatars.githubusercontent.com/u/23211?s=60&v=4){kind=small}
edmorley
approved these changes
Jan 13, 2025
edmorley
reviewed
Jan 13, 2025
| - header.tmpl.html | ||
| - index.tmpl.html | ||
| - nav.tmpl.html | ||
| - |
There was a problem hiding this comment.
@joshwlewis The Go CNB's output here seems to vary from run to run. Is this expected?
edmorley
reviewed
Jan 13, 2025
| - Running scripts | ||
| - No build scripts found | ||
| - Configuring default processes | ||
| - Skipping default web process (Procfile detected) | ||
|
|
||
| ! Warning: `node_modules` checked into source control |
There was a problem hiding this comment.
@colincasey I've just noticed the node_modules warning used to be shown here. This will be because these tutorials npm install the getting started guide locally and then perform a pack build locally too. And pack build will use whatever in the working directory rather than only what is git committed.
Should the Node.js getting started guide have an io.buildpacks.exclude entry in project.toml (the CNB equivalent of a .dockerignore) to exclude node_modules?
https://buildpacks.io/docs/reference/config/project-descriptor/#iobuildpacks-_table-optional_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generated by the run-rundoc linux github action