Speed up integration / namespace tests #148
Conversation
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
=========================================
+ Coverage 76.74% 77.5% +0.76%
=========================================
Files 30 30
Lines 890 907 +17
Branches 183 184 +1
=========================================
+ Hits 683 703 +20
+ Misses 184 182 -2
+ Partials 23 22 -1
Continue to review full report at Codecov.
|
ransombriggs
force-pushed
the
speed-up-tests
branch
from
30eaf2d to
9b5939e
Compare
|
👏 |
package.json
Outdated
| @@ -78,7 +81,7 @@ | |||
| "download": "node ./bin/download-yarn", | |||
| "prepare": "npm run clean && npm run build && npm run download", | |||
| "release": "np", | |||
| "test": "npm run download && jest -i && flow && standard", | |||
| "test": "npm run download && jest && flow && standard", | |||
There was a problem hiding this comment.
they still should be run in series though right? If the tests are doing things like installing and uninstalling plugins we can't be running things in parallel
There was a problem hiding this comment.
@dickeyxxx I have not run into any issues with this because it is installing to different directories, though there may be some issues with the yarn cache apparently. I could add --mutex to the yarn options to isolate this at the yarn level. Thoughts?
| @@ -2,5 +2,6 @@ coverage | |||
| lib | |||
| /node_modules | |||
| /test/links/test-foo/node_modules | |||
| /npm-packages-offline-cache | |||
There was a problem hiding this comment.
should we add this to the circle cache?
There was a problem hiding this comment.
@dickeyxxx added in a639907
|
seems appveyor is failing |
|
@dickeyxxx as always, windows eats out faces because of file locking, not sure if there is a good way around this as the code in the tmp dir is being Should I just file a different PR that only has the local cache changes for now? |
ransombriggs
force-pushed
the
speed-up-tests
branch
from
9a656f8 to
daa37a3
Compare
|
@dickeyxxx could you look at this again? I pushed up daa37a3 to fix appveyor |
@dickeyxxx could you review? This brings the test suite runtime down to about 20 seconds rather than about 40 seconds and make it possible to run offline. In order to get this done I made the following changes
yarn-offline-mirror "./npm-packages-offline-cache"to.yarnrcand add three local dependencies, one for each version ofheroku-debugthat the tests install. This way, it can download the versions tonpm-packages-offline-cachewithout having to hit the networklatest,alphaandcowabungareferences in tests to be the versions that they currently resolve to so that it does not have to check dist tags and can just use the caches--prefer-offlineinyarn.jsduring tests so that it checks local cache first