Add variant to hosts command

heroku · May 2, 2024 · 9232b99 · 9232b99
1 parent 2082582
commit 9232b99
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 13 deletions.
diff --git a/packages/cli/src/commands/spaces/hosts.ts b/packages/cli/src/commands/spaces/hosts.ts
@@ -28,9 +28,9 @@ export default class Hosts extends Command {
     }
 
     const {body: hosts} = await this.heroku.get<Host[]>(
-      `/spaces/${spaceName}/hosts`,
-      headers: {Accept: 'application/vnd.heroku+json; version=3.dogwood'}
-    )
+      `/spaces/${spaceName}/hosts`, {
+        headers: {Accept: 'application/vnd.heroku+json; version=3.dogwood'},
+      })
     if (flags.json)
       displayHostsAsJSON(hosts)
     else

diff --git a/packages/cli/test/unit/commands/spaces/hosts.unit.test.ts b/packages/cli/test/unit/commands/spaces/hosts.unit.test.ts
@@ -24,7 +24,11 @@ describe('spaces:hosts', function () {
   ]
 
   it('lists space hosts', async function () {
-    nock('https://api.heroku.com')
+    nock('https://api.heroku.com', {
+      reqheaders: {
+        Accept: 'application/vnd.heroku+json; version=3.dogwood',
+      },
+    })
       .get('/spaces/my-space/hosts')
       .reply(200, hosts)
     await runCommand(Cmd, [
@@ -42,7 +46,11 @@ describe('spaces:hosts', function () {
   })
 
   it('shows hosts:info --json', async function () {
-    nock('https://api.heroku.com')
+    nock('https://api.heroku.com', {
+      reqheaders: {
+        Accept: 'application/vnd.heroku+json; version=3.dogwood',
+      },
+    })
       .get('/spaces/my-space/hosts')
       .reply(200, hosts)
 

diff --git a/packages/cli/test/unit/commands/spaces/topology.unit.test.ts b/packages/cli/test/unit/commands/spaces/topology.unit.test.ts
@@ -6,12 +6,21 @@ import heredoc from 'tsheredoc'
 import expectOutput from '../../../helpers/utils/expectOutput'
 import * as fixtures from '../../../fixtures/spaces/fixtures'
 import {expect} from 'chai'
+import type {SpaceTopology} from '../../../../src/commands/spaces/topology'
+import {App} from '@heroku-cli/schema'
 
 describe('spaces:topology', function () {
-  const topo1 = fixtures.topologies['topology-one']
-  const topo2 = fixtures.topologies['topology-two']
-  const topo3 = fixtures.topologies['topology-three']
-  const app = fixtures.apps.www
+  let topo1: SpaceTopology
+  let topo2: SpaceTopology
+  let topo3: SpaceTopology
+  let app: App
+
+  beforeEach(function () {
+    topo1 = fixtures.topologies['topology-one']
+    topo2 = fixtures.topologies['topology-two']
+    topo3 = fixtures.topologies['topology-three']
+    app = fixtures.apps.www
+  })
 
   it('shows space topology', async function () {
     nock('https://api.heroku.com')

diff --git a/packages/cli/test/unit/commands/spaces/wait.unit.test.ts b/packages/cli/test/unit/commands/spaces/wait.unit.test.ts
@@ -7,19 +7,22 @@ import {expect} from 'chai'
 import expectOutput from '../../../helpers/utils/expectOutput'
 import * as fixtures from '../../../fixtures/spaces/fixtures'
 import * as sinon from 'sinon'
+import {Space} from '@heroku-cli/schema'
 
 describe('spaces:wait', function () {
-  const allocatingSpace = fixtures.spaces['allocating-space']
-  const allocatedSpace = fixtures.spaces['non-shield-space']
+  let allocatingSpace: Required<Space>
+  let allocatedSpace: Required<Space>
   let sandbox: sinon.SinonSandbox
   let notifySpy: sinon.SinonSpy
 
-  beforeEach(() => {
+  beforeEach(function () {
     sandbox = sinon.createSandbox()
     notifySpy = sandbox.spy(require('@heroku-cli/notifications'), 'notify')
+    allocatingSpace = fixtures.spaces['allocating-space']
+    allocatedSpace = fixtures.spaces['non-shield-space']
   })
 
-  afterEach(() => {
+  afterEach(function () {
     sandbox.restore()
   })