add typescript buildpack to heroku/nodejs builder #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielleadams
force-pushed
the
add-ts-buildpack
branch
3 times, most recently
from
25efad7
to
6948924
Compare
danielleadams
requested review from
jkutner and
joshwlewis
and removed request for
jkutner
…toml; add a Circle CI job to test for typescript buildpack compatibility
danielleadams
force-pushed
the
add-ts-buildpack
branch
from
6948924
to
849200b
Compare
jabrown85
approved these changes
Jul 9, 2020
elbandito
approved these changes
Jul 9, 2020
|
@danielleadams do we want this as part of the |
|
@hone I figured not for right now assuming that version of the buildpack is being used for Evergreen Dev Preview. I could though, and it wouldn't change the behavior of anyone already using TypeScript. |
|
yeah, it's fine for them to diverge, but I worry about having them too divergent for long periods if we intend to roll them together plus TypeScript is supported in Salesforce Functions. |
|
@hone yeah, that makes sense. I have to come back and change the test anyway once the typescript repo gets approved, so I look at adding it when I change the test. |
heroku-linguist bot
added a commit
that referenced
this pull request
Aug 25, 2023
## heroku/python ### Changed - Updated the default Python version from 3.11.4 to 3.11.5. ([#101](heroku/buildpacks-python#101)) ### Removed - Removed support for Salesforce Functions. ([#83](heroku/buildpacks-python#83)) Co-authored-by: edmorley <edmorley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds TypeScript buildpack from release v0.0.2. For now, the buildpack is only available in the Heroku meta buildpack.
This pull request also includes an added test in CI. The getting started guide (https://github.com/danielleadams/typescript-getting-started) is being reviewed by Salesforce OSS, so it will be able to use the same Job once the repo gets approved.
Context
As we move towards creating a great Node experience for JavaScript developers, we want to make sure that the TypeScript experience is just as good. By adding supporting a TS buildpack, we can make data and feedback-based enhancements to the DX for developers using CNBs.