Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lifecycle from v0.16.1 to v0.17.0 #377

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Conversation

@edmorley edmorley self-assigned this Aug 19, 2023
@edmorley
Copy link
Member Author

edmorley commented Aug 19, 2023

Hmm the new lifecycle output is quite verbose, eg:

===> ANALYZING
Timer: Analyzer started at 2023-08-19T15:09:42Z
Image with name "getting-started" not found
Timer: Analyzer ran for 33.202µs and ended at 2023-08-19T15:09:42Z
===> DETECTING
Timer: Detector started at 2023-08-19T15:09:42Z
heroku/python   0.5.0
heroku/procfile 2.0.0
Timer: Detector ran for 6.10975ms and ended at 2023-08-19T15:09:42Z
===> RESTORING

(https://github.com/heroku/builder/actions/runs/5912102145/job/16035204379?pr=377#step:6:7)

I'll report a few suggestions upstream next week.

@edmorley edmorley marked this pull request as ready for review August 21, 2023 10:20
@edmorley edmorley requested a review from a team as a code owner August 21, 2023 10:20
@edmorley
Copy link
Member Author

I've filed GUS-W-13981419 to track reporting this upstream.

In the meantime we can still merge this, since the verbosity increase is tolerable, and it would be good to pick up the other changes in 0.17.0.

@edmorley edmorley merged commit 11282fe into main Aug 21, 2023
34 checks passed
@edmorley edmorley deleted the edmorley/update-lifecycle branch August 21, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants