Lockfiles for Node Functions examples #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
approved these changes
Oct 25, 2023
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
This was referenced Oct 25, 2023
edmorley
added a commit
that referenced
this pull request
Oct 25, 2023
The example functions fixtures in this repo are only needed to provide a quick smoke test of building a function using the functions builder image (primarily to ensure that the builder order grouping is correct). All other CNB functionality should (and is) tested in the CNB or function invoker itself. This means the testing/linting related files in the fixtures is unused and can be removed, Doing so will prevent an endless stream of Dependabot security alert PRs for Node.js dev/test dependencies (eg: #419, #420, #422), now that we have committed the NPM lockfiles (xref #418). GUS-W-14364076.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To unblock #417. There is no reason why these examples shouldn't have lockfiles in place.