Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce builder-24 with multi-arch support #504

Merged
merged 23 commits into from
May 3, 2024
Merged

Introduce builder-24 with multi-arch support #504

merged 23 commits into from
May 3, 2024

Conversation

joshwlewis
Copy link
Member

@joshwlewis joshwlewis commented May 2, 2024

This introduces a multi-arch builder with buildpacks that support both linux/amd64 and linux/arm64 based on heroku-24. For now, that's limited to heroku/go and heroku/procfile. More languages will be added as they gain linux/arm64 support.

This makes use of the GitHub Actions arm runners beta to build the arm images. These runners don't have docker so there are some additional manual install steps.

Example successful run: https://github.com/heroku/cnb-builder-images/actions/runs/8941039965/job/24560480143

GUS-W-14658981.
GUS-W-15158337.

@joshwlewis joshwlewis requested a review from a team as a code owner May 2, 2024 19:06
@joshwlewis joshwlewis marked this pull request as draft May 2, 2024 19:06
@joshwlewis joshwlewis removed the request for review from a team May 2, 2024 19:07
@joshwlewis joshwlewis changed the title Basic builder-24 Introduce builder-24 with multi-arch May 3, 2024
@joshwlewis joshwlewis changed the title Introduce builder-24 with multi-arch Introduce builder-24 with multi-arch support May 3, 2024
@joshwlewis joshwlewis marked this pull request as ready for review May 3, 2024 15:15
@joshwlewis joshwlewis requested a review from a team May 3, 2024 15:27
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

.github/workflows/build-test-publish.yml Show resolved Hide resolved
README.md Show resolved Hide resolved
@joshwlewis joshwlewis enabled auto-merge (squash) May 3, 2024 16:51
@joshwlewis joshwlewis merged commit 4797819 into main May 3, 2024
47 checks passed
@joshwlewis joshwlewis deleted the builder-24 branch May 3, 2024 17:05
edmorley added a commit to heroku/languages-github-actions that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants