Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .NET buildpack #571

Merged
merged 10 commits into from
Aug 29, 2024
Merged

Add .NET buildpack #571

merged 10 commits into from
Aug 29, 2024

Conversation

runesoerensen
Copy link
Contributor

@runesoerensen runesoerensen commented Aug 29, 2024 •
edited
Loading

Adding the .NET buildpack to heroku/builder:22 and heroku/builder:24.

@runesoerensen runesoerensen requested a review from a team as a code owner August 29, 2024 08:27
@runesoerensen runesoerensen added enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels Aug 29, 2024
@runesoerensen runesoerensen self-assigned this Aug 29, 2024
edmorley
edmorley reviewed Aug 29, 2024
View reviewed changes
.github/workflows/build-test-publish.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
runesoerensen and others added 5 commits August 29, 2024 04:47
@runesoerensen @edmorley
Remove whitespace
58587ed 
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
@runesoerensen @edmorley
Fix typo
486a76d 
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
@runesoerensen
Add heroku/dotnet to builder-22
5416650
@runesoerensen
Update Readme
b0e3cab
@runesoerensen
Don't exclude dotnet from builder-22
91743ec
@runesoerensen runesoerensen changed the title Add .NET buildpack to builder:24 Add .NET buildpack to builder:22+24 Aug 29, 2024
@runesoerensen runesoerensen changed the title Add .NET buildpack to builder:22+24 Add .NET buildpack Aug 29, 2024
@runesoerensen runesoerensen enabled auto-merge (squash) August 29, 2024 17:48
edmorley
edmorley approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@runesoerensen runesoerensen merged commit c5306c7 into main Aug 29, 2024
45 checks passed
@runesoerensen runesoerensen deleted the add-dotnet-buildpack-to-builder-24 branch August 29, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colincasey colincasey colincasey left review comments

@edmorley edmorley edmorley approved these changes

Assignees

@runesoerensen runesoerensen

Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@runesoerensen @colincasey @edmorley