Add develop binary #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabrown85
force-pushed
the
jab/add-cnb-develop
branch
from
2ca6158 to
9b4d93f
Compare
jabrown85
commented
Jun 10, 2020
| - run: docker load < pack-18-build.tar | ||
| - run: docker load < pack-18-riff-build.tar | ||
| - run: | | ||
| if [ -f "pack-18-build.tar" ]; then |
There was a problem hiding this comment.
FYI: The riff-build additional image caused this to fail on fresh branch builds. This will go away in a followup pr as we no longer need the riff-build image at all.
There was a problem hiding this comment.
@jabrown85 does this mean the RIFF=1 is no longer required?
There was a problem hiding this comment.
Correct. In the next PR I'll get rid of it.
elbandito
approved these changes
Jun 10, 2020
heroku-linguist bot
added a commit
that referenced
this pull request
Mar 3, 2025
## heroku/deb-packages ### Changed - Updated libcnb to 0.27.0, which includes opentelemetry 0.28 and the new custom OTLP File Exporter. ([#95](heroku/buildpacks-deb-packages#95))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The s3 bucket is the destination for the heroku/cnb-develop releases. The builder binaries will always pull the latest release so any changes to cnb-develop will get brought to users on at least a nightly cadence via the builder image.
I put it in
/cnb/lifecycle/, but am open to other locations :)