-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect installed paths and update PATH and LD_LIBRARY_PATH accordingly #39
base: master
Are you sure you want to change the base?
Conversation
a1c0502
to
eff6af0
Compare
Quoted $PROFILE_PATH variable usage Hardened $BUILD_DIR to $HOME sed replacement
@duanehutchins I tested this with |
Is anything blocking this from upstream? 👩🔬 |
It's been a while, but this PR would be wonderful to get in 😢 |
@KevinBrolly apologies if you aren't associated with this project -- just hoping someone from heroku could comment on this PR. The above fixes issues for me -- makes it possible to install chromium dependencies with an entry like this in Aptfile
Without it LD_LIBRARY_PATH seems to be incorrect and chromium fails to find libcairo ... I'd be interested in updating the PR to address any concerns so it could be merged if could know what the concerns were that prevented merging this a year ago? |
Hey guys, tonight/tomorrow I will update this PR (and duanehutchins/heroku-buildpack-apt) to include newer commits from this repo and resolve any conflicts. I'll also add Hopefully, @heroku will be more willing to merge after that, and if any contributors are reading this, please let me know if there's any steps I should take to get this PR merged. |
👋 - it's now 2021. @schneems - We could really use this (if you're still at Heroku that is). |
…_PATH" accordingly #39
LD_LIBRARY_PATH
LD_LIBRARY_REGEX_PATTERNS
, and matching directories will also be included inLD_LIBRARY_PATH
PATH
BUILD_DIR
is used as base directory for writing to export (used by other buildpacks during build).HOME
is used as the base directory for writing to .profile.d (used by app after deploying)--force-yes is deprecated
warning. (thanks @reacuna)This PR will satisfy several reported issues/pulls: #10 #16 #20 #27 #28 #36 #38