Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect installed paths and update PATH and LD_LIBRARY_PATH accordingly #39

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

duanehutchins
Copy link

  • Detects existing lib/* paths and adds them to LD_LIBRARY_PATH
  • New functionality to pass colon-delimited regex patterns via LD_LIBRARY_REGEX_PATTERNS, and matching directories will also be included in LD_LIBRARY_PATH
  • Detects existing "bin" and "sbin" directories and adds them to PATH
  • To fix bugs with mismatching variables during build/deploy:
    • BUILD_DIR is used as base directory for writing to export (used by other buildpacks during build).
    • HOME is used as the base directory for writing to .profile.d (used by app after deploying)
  • This PR also includes PR Remove deprecated option and use noninteractive instead #36 to fix the --force-yes is deprecated warning. (thanks @reacuna)

This PR will satisfy several reported issues/pulls: #10 #16 #20 #27 #28 #36 #38

Quoted $PROFILE_PATH variable usage
Hardened $BUILD_DIR to $HOME sed replacement
@mmerickel
Copy link

@duanehutchins I tested this with https://downloads.wkhtmltopdf.org/0.12/0.12.5/wkhtmltox_0.12.5-1.bionic_amd64.deb and it did not add it to the path. The issue here is that it installs naturally into /usr/local/bin, not /usr/bin and is thus available in /app/.apt/usr/local/bin which is being missed.

@Teemu
Copy link

Teemu commented Jan 9, 2019

Is anything blocking this from upstream? 👩‍🔬

@felixrieseberg
Copy link

It's been a while, but this PR would be wonderful to get in 😢

@breathe
Copy link

breathe commented Nov 20, 2019

@KevinBrolly apologies if you aren't associated with this project -- just hoping someone from heroku could comment on this PR. The above fixes issues for me -- makes it possible to install chromium dependencies with an entry like this in Aptfile

gconf-service libappindicator1 libasound2 libatk1.0-0 libatk-bridge2.0-0 libcairo-gobject2 libgconf-2-4 libgtk-3-0 libnspr4 libnss3 libx11-xcb1 libxcomposite1 libxcursor1 libxdamage1 libxfixes3 libxi6 libxinerama1 libxrandr2 libxss1 libxtst6 fonts-liberation

Without it LD_LIBRARY_PATH seems to be incorrect and chromium fails to find libcairo ...

I'd be interested in updating the PR to address any concerns so it could be merged if could know what the concerns were that prevented merging this a year ago?

@duanehutchins
Copy link
Author

Hey guys, tonight/tomorrow I will update this PR (and duanehutchins/heroku-buildpack-apt) to include newer commits from this repo and resolve any conflicts. I'll also add /usr/local/bin/ as per @mmerickel's note above.

Hopefully, @heroku will be more willing to merge after that, and if any contributors are reading this, please let me know if there's any steps I should take to get this PR merged.

@danielricecodes
Copy link

danielricecodes commented Sep 21, 2021

👋 - it's now 2021. @schneems - We could really use this (if you're still at Heroku that is).

marota referenced this pull request in marota/heroku-buildpack-apt Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants