Skip to content

Commit

Permalink
Fix packages on Heroku-24
Browse files Browse the repository at this point in the history
Fixes this error:

```
chrome: error while loading shared libraries: libasound.so.2: cannot open shared object file: No such file or directory
```

And also cleans up the packages list, removing some packages that
either are no longer needed, or already exist in the base image. This
is safe to do now that `bin/test.sh` checks for missing shared libraries.
  • Loading branch information
edmorley committed May 30, 2024
1 parent 2e56446 commit 5894869
Showing 1 changed file with 10 additions and 22 deletions.
32 changes: 10 additions & 22 deletions bin/install-chrome-dependencies
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@
topic "Installing Chrome dependencies"

# Install correct dependencies according to $STACK
# The package list is validated by bin/test.sh - see its output to identify any missing libraries.
# Also look here for more packages/notes https://developers.google.com/web/tools/puppeteer/troubleshooting
case "${STACK}" in
"heroku-20" | "heroku-22" )
# the package list is found by using ci:debug then running ldd $GOOGLE_CHROME_BIN | grep not
# also look here for more packages/notes https://developers.google.com/web/tools/puppeteer/troubleshooting
"heroku-20" | "heroku-22")
PACKAGES="
gconf-service
libappindicator1
Expand Down Expand Up @@ -47,31 +47,19 @@ case "${STACK}" in
"
;;
"heroku-24")
# the package list is found by using ci:debug then running ldd $GOOGLE_CHROME_BIN | grep not
# also look here for more packages/notes https://developers.google.com/web/tools/puppeteer/troubleshooting
PACKAGES="
libatk1.0-0
PACKAGES=(
fonts-liberation
libasound2t64
libatk-bridge2.0-0
libcairo-gobject2
libdrm2
libatk1.0-0
libcups2
libgbm1
libgtk-3-0
libnspr4
libnss3
libx11-xcb1
libxcb-dri3-0
libxcomposite1
libxcursor1
libxdamage1
libxfixes3
libxi6
libxinerama1
libxkbcommon0
libxrandr2
libxshmfence1
libxss1
libxtst6
fonts-liberation
"
)
;;
*)
error "STACK must be 'heroku-20', 'heroku-22' or 'heroku-24', not '${STACK}'."
Expand Down

0 comments on commit 5894869

Please sign in to comment.