Stop installing unnecessary packages #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Trims the APT package list for Heroku-20 and Heroku-22 to match the packages list used for Heroku-24. - Uses `--no-install-recommends` to avoid pulling in unnecessary transitive dependencies. - Now outputs the size of the app dir when running tests (plus removes test containers after they exit). The tests added in #15 ensure that there are no missing dynamically linked libraries, and that Chrome + Chromedriver can start. This reduces the uncompressed slug size impact of this buildpack as follows: - Heroku-20: 442 MB -> 350 MB - Heroku-22: 426 MB -> 351 MB - Heroku-24: 381 MB -> 353 MB Fixes #17.
edmorley
force-pushed
the
edmorley/fewer-packages
branch
from
0e295b7 to
eaf01f8
Compare
mars
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*t64package name differences due to Ubuntu 24.04's 64-bittime_tmigration).--no-install-recommendsto avoid pulling in unnecessary transitive dependencies.The tests added in #15 ensure that there are no missing dynamically linked libraries, and that Chrome + Chromedriver can start.
This reduces the uncompressed slug size impact of this buildpack as follows:
Fixes #17.
GUS-W-16148742.