Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report errors when curl fails #533

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Report errors when curl fails #533

merged 2 commits into from
Jan 3, 2024

Conversation

joshwlewis
Copy link
Member

Currently, failures to download the Go distribution from S3 look like this:

    remote: -----> Installing go1.20.8        
    remote: -----> Fetching go1.20.8.linux-amd64.tar.gz...  !     Push rejected, failed to compile Go app.        
    remote: 
    remote:  !     Push failed    

We're using the -s (--silent) flag, so there's no further detail about why the download failed. Adding --show-error to curl will give customers and support agents more context on the reason for the failure.

@joshwlewis joshwlewis requested a review from a team as a code owner January 3, 2024 16:01
@joshwlewis joshwlewis merged commit b9a1f17 into main Jan 3, 2024
4 checks passed
@joshwlewis joshwlewis deleted the curl-show-error branch January 3, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants