Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect developers to use Chrome for Testing buildpack #150

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

mars
Copy link
Member

@mars mars commented Mar 15, 2024

Some developers may use Chrome without Chromedriver, but for all the others, redirect them to the Chrome for Testing buildpack that installs matching versions of Chrome + Chromedriver.

See the rendered README.

Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update bin/compile to emit a build log warning?

@edmorley
Copy link
Member

Could you also update bin/compile to emit a build log warning?

Oh sorry thought I was commenting on heroku/heroku-buildpack-chromedriver#66

I suppose for this repo a warning in the build log might be too much, given that you say there may be some people who aren't using Chrome with selenium etc?

That said, might Chrome for Testing still more appropriate for non-selenium use-cases too? It feels like the new buildpack uses a more sustainable approach in general (that doesn't have to install lots of transitive library deps; I presume because Chrome for Testing is statically linked?), and it would be good to not have to maintain two buildpacks.

@mars
Copy link
Member Author

mars commented Mar 18, 2024

@edmorley Chrome for Testing still requires installation of many dependencies.

I really don't know everyway this Chrome-only buildpack could be used, and it has some nuanced aspects of wrapping the executable, which the Chrome for Testing buildpack does not do. I am doing my best to make progress to solve the Chromedriver compatibility problem, and completely sunsetting this Chrome-only buildpack feels out-of-scope.

@edmorley
Copy link
Member

Chrome for Testing still requires installation of many dependencies.

Oh sorry since that was in a separate script, I didn't see a list of packages when I skim-read bin/compile very briefly earlier.

@mars mars merged commit cfcb226 into master Mar 18, 2024
11 checks passed
@mars mars deleted the consider-chrome-for-testing branch March 18, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants