Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit deprecations for Heroku 20 + 22, errors for 24 #154

Merged
merged 3 commits into from
May 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
test:
strategy:
matrix:
stack: [heroku-18, heroku-20, heroku-22]
stack: [heroku-20, heroku-22]
channel: [stable, beta, unstable]
runs-on: ubuntu-latest

Expand Down
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
# Change Log
All notable changes to this project will be documented in this file.

## [Unreleased]
## 2024-05-30
- Deprecates support in Heroku-22 and Heroku-20.
- Adds explicit error for Heroku-24

## 2022-05-19
- Added support for Heroku-22.
Expand Down
1 change: 1 addition & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
ARG BASE_IMAGE
FROM $BASE_IMAGE
USER root

ARG STACK
ARG GOOGLE_CHROME_CHANNEL
Expand Down
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## WARNING: `heroku-buildpack-google-chrome` is deprecated

This buildpack is deprecated and is no longer being maintained. Use (https://github.com/heroku/heroku-buildpack-chrome-for-testing.

# heroku-buildpack-google-chrome

This buildpack downloads and installs (headless) Google Chrome from your choice
Expand Down
7 changes: 7 additions & 0 deletions bin/compile
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,14 @@ esac

# Install correct dependencies according to $STACK
case "${STACK}" in
"heroku-24")
error "This buildpack has reached end of life. Please use https://github.com/heroku/heroku-buildpack-chrome-for-testing"
;;
"heroku-18" | "heroku-20" | "heroku-22")
topic "###### WARNING ######"
topic "This buildpack is deprecated. Please use https://github.com/heroku/heroku-buildpack-chrome-for-testing"
topic "#####################"

# the package list is found by using ci:debug then running ldd $GOOGLE_CHROME_BIN | grep not
# also look here for more packages/notes https://developers.google.com/web/tools/puppeteer/troubleshooting
PACKAGES="
Expand Down
Loading