Skip to content

Commit

Permalink
Pin to pip 9.0.2 for pipenv users only
Browse files Browse the repository at this point in the history
This addresses an issue raised by @CaseyFeist during code review:

  Updating pip for pipenv users or requiring them to update without a
  heads up won't be a good experience (our version is old enough that
  they'll need to uninstall and reinstall pipenv locally to successfully
  update). If you can refactor this to stay pinned to current version for
  pipenv users only, I should be able to accept this (and the related
  project updates).

  #833 (comment)
  • Loading branch information
cjolowicz committed Oct 3, 2019
1 parent b4e7ef7 commit 8408e34
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions bin/compile
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,11 @@ for file in "$BUILD_DIR/runtime.txt" "$CACHE_DIR/.heroku/python-version" ; do
esac
done

if [[ -f "$BUILD_DIR/Pipfile" ]]; then
# Do not force pipenv users to re-install pipenv locally.
PIP_UPDATE="9.0.2"
fi

export DEFAULT_PYTHON_STACK PIP_UPDATE
export PY37 PY36 PY35 PY27 PY34

Expand Down

1 comment on commit 8408e34

@CaseyFaist
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect 🎉 thanks!

Please sign in to comment.