Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pipenv version #701

Merged
merged 3 commits into from
May 29, 2018
Merged

Conversation

allyjweir
Copy link

@allyjweir allyjweir commented May 21, 2018

We are depending on some of the bug fixes released between the last version and 11.10.4 (VCS package related issues). Having updated locally for our dev envrionments, thought it was worthwhile to bump the version in the buildpack in use too.

@allyjweir
Copy link
Author

Tests are failing on Travis:

testPipenvLock
ASSERT:Captured exit code - expected:<0> but was:<1>
-----> Installing python-3.6.5
-----> Installing pip
-----> Installing dependencies with Pipenv 11.10.4…
       Your Pipfile.lock (d26635) is out of date. Expected: (00ad98).
       Aborting deploy.

I went into the fixtures for the failing test and tried running pipenv lock to regenerate the Pipenv.lock file. Unfortunately this didn't generate a new lockfile with the required hash. @kennethreitz (or any other maintainer with pipenv experience!), any advice on how to resolve this issue?

Thanks in advance.

@kennethreitz
Copy link
Contributor

that should do the trick!

@allyjweir
Copy link
Author

Figured out my issue. My local install of pipenv wasn't at latest version so was getting different hash when running pipenv lock using my local machine.

Now getting a shellcheck failure on Travis but not locally. Will update as I progress...

@sigmavirus24
Copy link
Contributor

@hone this looks good to me. I updated the branch so it would merge cleanly. (I had missed that @allyjweir had fixed the shellcheck violations.) Would you mind giving this a look over as well for compliance?

@hone
Copy link
Member

hone commented May 25, 2018

Looks good to me. @sigmavirus24 feel free to merge on Monday.

@sigmavirus24 sigmavirus24 merged commit dbeca14 into heroku:master May 29, 2018
@allyjweir allyjweir deleted the bump-pipenv-version branch May 31, 2018 12:49
@allyjweir
Copy link
Author

What's the process for this becoming in use in Heroku dynos?

@KevinBrolly
Copy link
Contributor

@allyjweir This pull request was release with V135 so it is now available to run on your dynos, next time you do a build it should pick up the new version.

P.S I also used to work at Twig, say hi to everyone for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants