-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pipenv version #701
Bump pipenv version #701
Conversation
Tests are failing on Travis:
I went into the fixtures for the failing test and tried running Thanks in advance. |
that should do the trick! |
5c3025b
to
7c6277a
Compare
Figured out my issue. My local install of Now getting a shellcheck failure on Travis but not locally. Will update as I progress... |
7c6277a
to
f1e1df2
Compare
@hone this looks good to me. I updated the branch so it would merge cleanly. (I had missed that @allyjweir had fixed the shellcheck violations.) Would you mind giving this a look over as well for compliance? |
Looks good to me. @sigmavirus24 feel free to merge on Monday. |
What's the process for this becoming in use in Heroku dynos? |
@allyjweir This pull request was release with V135 so it is now available to run on your dynos, next time you do a build it should pick up the new version. P.S I also used to work at Twig, say hi to everyone for me! |
We are depending on some of the bug fixes released between the last version and 11.10.4 (VCS package related issues). Having updated locally for our dev envrionments, thought it was worthwhile to bump the version in the buildpack in use too.