Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[changelog skip] Hatchet Regression Tests #969

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

schneems
Copy link
Contributor

@schneems schneems commented Apr 24, 2020

I went through all the tests in the Ruby buildpack and cataloged what I think can be generalized between languages to prevent regressions. This PR add tests for these cases:

  • Test CI deploys run tests and use the cache [reference test]
  • Test cache for regular deploys is used on repeated deploys (This was already tested on the Python buildpack, I moved it) [reference test]
    • Test modifying a requirement clears the cache appropriately (This was already tested on the Python buildpack, I moved it)
  • Test deploying the getting started guide works [reference test]
  • Test that all paths set by the buildpack are absolute instead of relative [reference test]
  • Test upgrading stack invalidates the cache [reference test]
  • Test that builds fail when a bad version is specified [reference test]

In addition to that I've also got a CNB test with pack-build with the getting started app, but since python isn't cnb capable yet I didn't add one.

@schneems schneems changed the title WIP [ci skip] WIP Apr 24, 2020
@schneems schneems force-pushed the schneems/test-absolute-path branch 3 times, most recently from a8e2289 to a2ca457 Compare April 24, 2020 20:44
I went through all the tests in the Ruby buildpack and cataloged what I think can be generalized between languages to prevent regressions. This PR add tests for these cases:

* Test CI deploys run tests and use the cache [[reference test](https://github.com/heroku/heroku-buildpack-ruby/blob/f488bd53c7ff0b78e17c2405166cbd4a3af75ee2/spec/hatchet/ci_spec.rb#L36)]
* Test cache for regular deploys is used on repeated deploys (This was already tested on the Python buildpack, I moved it) [[reference test](https://github.com/heroku/heroku-buildpack-ruby/blob/e34c583c139911d059f5627bb25125707288f053/spec/hatchet/stack_spec.rb#L21-L25)]
    * Test modifying a requirement clears the cache appropriately (This was already tested on the Python buildpack, I moved it)
* Test deploying the getting started guide works [[reference test](https://github.com/heroku/heroku-buildpack-ruby/blob/424a7245e2da86845a20d58a9482bcf2a00c3a8f/spec/hatchet/getting_started_spec.rb#L5)]
* Test that all paths set by the buildpack are absolute instead of relative [[reference test](https://github.com/heroku/heroku-buildpack-ruby/blob/249d3c1a4e97068f8fd016f10fa0839709d95658/spec/hatchet/rails5_spec.rb#L68])
* Test upgrading stack invalidates the cache [[reference test](https://github.com/heroku/heroku-buildpack-ruby/blob/f488bd53c7ff0b78e17c2405166cbd4a3af75ee2/spec/hatchet/stack_spec.rb#L3)]
* Test that builds fail when a bad version is specified [[reference test](https://github.com/heroku/heroku-buildpack-ruby/blob/249d3c1a4e97068f8fd016f10fa0839709d95658/spec/hatchet/ruby_spec.rb#L5)]


In addition to that I've also got a CNB test with `pack-build` with the getting started app, but since python isn't `cnb` capable yet I didn't add one.
@schneems schneems force-pushed the schneems/test-absolute-path branch from a2ca457 to 2997c2b Compare April 24, 2020 21:10
@schneems schneems changed the title [ci skip] WIP Hatchet Regression Tests Apr 24, 2020
@schneems schneems changed the title Hatchet Regression Tests [changelog skip] Hatchet Regression Tests Apr 24, 2020
@schneems schneems marked this pull request as ready for review April 24, 2020 21:36
@schneems schneems requested a review from a team as a code owner April 24, 2020 21:36
@jkutner jkutner merged commit a06b536 into master Apr 27, 2020
@jkutner jkutner deleted the schneems/test-absolute-path branch April 27, 2020 13:26
@schneems
Copy link
Contributor Author

This work needs heroku/hatchet#80 merged and the hatchet version updated

@schneems
Copy link
Contributor Author

Done making PR #970

dryan pushed a commit to dryan/heroku-buildpack-python that referenced this pull request Nov 19, 2020
I went through all the tests in the Ruby buildpack and cataloged what I think can be generalized between languages to prevent regressions. This PR add tests for these cases:

* Test CI deploys run tests and use the cache [[reference test](https://github.com/heroku/heroku-buildpack-ruby/blob/f488bd53c7ff0b78e17c2405166cbd4a3af75ee2/spec/hatchet/ci_spec.rb#L36)]
* Test cache for regular deploys is used on repeated deploys (This was already tested on the Python buildpack, I moved it) [[reference test](https://github.com/heroku/heroku-buildpack-ruby/blob/e34c583c139911d059f5627bb25125707288f053/spec/hatchet/stack_spec.rb#L21-L25)]
    * Test modifying a requirement clears the cache appropriately (This was already tested on the Python buildpack, I moved it)
* Test deploying the getting started guide works [[reference test](https://github.com/heroku/heroku-buildpack-ruby/blob/424a7245e2da86845a20d58a9482bcf2a00c3a8f/spec/hatchet/getting_started_spec.rb#L5)]
* Test that all paths set by the buildpack are absolute instead of relative [[reference test](https://github.com/heroku/heroku-buildpack-ruby/blob/249d3c1a4e97068f8fd016f10fa0839709d95658/spec/hatchet/rails5_spec.rb#L68])
* Test upgrading stack invalidates the cache [[reference test](https://github.com/heroku/heroku-buildpack-ruby/blob/f488bd53c7ff0b78e17c2405166cbd4a3af75ee2/spec/hatchet/stack_spec.rb#L3)]
* Test that builds fail when a bad version is specified [[reference test](https://github.com/heroku/heroku-buildpack-ruby/blob/249d3c1a4e97068f8fd016f10fa0839709d95658/spec/hatchet/ruby_spec.rb#L5)]


In addition to that I've also got a CNB test with `pack-build` with the getting started app, but since python isn't `cnb` capable yet I didn't add one.
dryan pushed a commit to dryan/heroku-buildpack-python that referenced this pull request Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants