Skip to content

Commit

Permalink
Fix tests not executing (#1517)
Browse files Browse the repository at this point in the history
* Emit log order

Issue #1505 spells out a problem where it appears ci-queue does not fail even when the test suite is broken. I'm unsure why this happens. To debug I'm emitting the tests that run so I can audit to make sure `rspec ./spec/helpers/yarn_installer_spec.rb:6` is executed.

If it's not, then I need to diagnose why. If it is, then perhaps there some ordering bug that's affecting the outcome.

* Update CI-queue

* Update redis version

* Use branch of ci-queue
  • Loading branch information
schneems authored Nov 13, 2024
1 parent adc4484 commit a3f4f66
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ group :development, :test do
gem "parallel_tests"
gem 'rspec-retry'
gem 'json'
gem 'ci-queue'
gem 'ci-queue', github: "schneems/ci-queue", branch: "schneems/allow-hosted-redis"
gem 'redis'
gem 'dead_end'
end
14 changes: 11 additions & 3 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,8 +1,15 @@
GIT
remote: https://github.com/schneems/ci-queue.git
revision: 285353ba8bc58e1b2ed02dedf55730400c27e32b
branch: schneems/allow-hosted-redis
specs:
ci-queue (0.58.0)
logger

GEM
remote: https://rubygems.org/
specs:
base64 (0.2.0)
ci-queue (0.55.0)
citrus (3.0.2)
connection_pool (2.4.1)
dead_end (4.0.0)
Expand All @@ -23,6 +30,7 @@ GEM
thor (~> 1)
threaded (~> 0)
json (2.7.2)
logger (1.6.1)
moneta (1.0.0)
multi_json (1.15.0)
parallel (1.25.1)
Expand All @@ -34,7 +42,7 @@ GEM
rate_throttle_client (~> 0.1.0)
rake (13.2.1)
rate_throttle_client (0.1.2)
redis (5.2.0)
redis (5.3.0)
redis-client (>= 0.22.0)
redis-client (0.22.2)
connection_pool
Expand All @@ -57,7 +65,7 @@ PLATFORMS
ruby

DEPENDENCIES
ci-queue
ci-queue!
dead_end
excon
heroku_hatchet
Expand Down
2 changes: 1 addition & 1 deletion app.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
},
"scripts": {
"test-setup": "bundle exec rake hatchet:setup_ci",
"test": "bundle exec rspec-queue --max-requeues=3 --timeout 180 --queue $REDIS_URL || { cat log/test_order.log; $(exit 1); }"
"test": "bundle exec rspec-queue --max-requeues=3 --timeout 180 --queue $REDIS_URL --format documentation || { cat log/test_order.log; $(exit 1); }"
},
"buildpacks": [
{
Expand Down

0 comments on commit a3f4f66

Please sign in to comment.