Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gemfile w/ duplicate path gems fails with Bundler > 2.2.7 #1135

Closed
internets opened this issue Mar 1, 2021 · 4 comments
Closed

Gemfile w/ duplicate path gems fails with Bundler > 2.2.7 #1135

internets opened this issue Mar 1, 2021 · 4 comments

Comments

@internets
Copy link

When #1132 was merged our build began to fail due to a bug introduce in Bundler 2.2.8. I submitted a bugfix PR that was just incorporated in the latest 2.2.12 release. I understand that updating bundler in the ruby buildpack is not done lightly, so please let me know if an update is not in the cards :)

If 2.2.12 doesn't pass muster we will happily maintain a monkeypatch with a version check to remind us to remove it when it is updated, so no rush!

Bundler 2.2.12 changelog: https://github.com/rubygems/rubygems/blob/bundler-v2.2.12/bundler/CHANGELOG.md#2212-march-1-2021

schneems added a commit that referenced this issue Mar 4, 2021
Bundler 2.2.11 contains an issue with "duplicate path gems" that is resolved in 2.2.12.
@schneems
Copy link
Contributor

schneems commented Mar 4, 2021

Working on this in #1140

I'll likely not release until next week though.

@schneems
Copy link
Contributor

schneems commented Mar 4, 2021

Tests are failing on that branch but still work on main:

       remote:        Gem::Ext::BuildError: ERROR: Failed to build gem native extension.        
       remote:                
       remote:        current directory:        
       remote:        /tmp/build_392437cc/vendor/bundle/jruby/2.5.0/gems/naether-0.15.7-java        
       remote:        jrake        
       remote:        RUBYARCHDIR=/tmp/build_392437cc/vendor/bundle/jruby/2.5.0/extensions/universal-java-1.8/2.5.0/naether-0.15.7-java        
       remote:        RUBYLIBDIR=/tmp/build_392437cc/vendor/bundle/jruby/2.5.0/extensions/universal-java-1.8/2.5.0/naether-0.15.7-java        
       remote:        sh: 1: jrake: not found        

This might be a regression in bundler. I'll have to investigate more.

@internets
Copy link
Author

Thanks! No rush, glad to know it's in progress.

That test failure does look like a bundler regression in 2.2.12. I suspect it's fixed by rubygems/rubygems#4428

@internets
Copy link
Author

Closed by #1140 -- thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants