Support TAP output for CI #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/support-TAP-ci-output
branch
from
195f735 to
0676b3f
Compare
The TAP specification says that there should be no whitespace in front of output. The `pipe` command auto indents output so that it looks correct with the build output. This PR adds the ability to specify the object that is used for puts. We can pass in the `Kernel` object to force it to not indent output. Related support ticket: 605130
schneems
force-pushed
the
schneems/support-TAP-ci-output
branch
from
41c18bf to
c290668
Compare
hone
reviewed
Jul 24, 2018
| # having no whitespace before output. To avoid adding whitespace | ||
| # for the original Kernel.puts to be used by passing in the | ||
| # Kernel object. | ||
| pipe(command, :user_env => true, :output_object => Kernel) |
There was a problem hiding this comment.
By default we want the indent or this code change would be much larger. We're depending on the indent for the output to look correct when we do things like bundle install on a normal build.
hone
approved these changes
Jul 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TAP specification says that there should be no whitespace in front of output. The
pipecommand auto indents output so that it looks correct with the build output.This PR adds the ability to specify the object that is used for puts. We can pass in the
Kernelobject to force it to not indent output.Related support ticket: 605130