Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean old bundler binstubs on load #914

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Conversation

hone
Copy link
Member

@hone hone commented Sep 6, 2019

It looks like there's a bug with bundle clean, where it doesn't clean up binstubs that aren't used. This patch removes the vendor/bundle/bin directory on cache load. Bundler will regenerate the binstubs even if no new gems need to be installed.

@hone hone requested a review from schneems September 6, 2019 22:27
@schneems
Copy link
Contributor

Internal support reference https://heroku.support/764500

The broad issue was the customer used to have the heroku gem in their gemfile which generated a binstub. They then later added the heroku CLI buildpack which should give them access to a heroku command, however the binstub from the heroku gem still took priority, even once the gem was removed from the Gemfile and re-deployed.

I'm going to try to reproduce this behavior with a dockerfile so I can report to bundler and we can get it fixed upstream as well.

@schneems
Copy link
Contributor

Waiting on CI to have a successful run, also re-visiting #890 to help with making progress on the flappy tests.

@schneems
Copy link
Contributor

Merging in, will let it sit on master for a bit before deploying.

Also, I'm realizing we didn't do a changelog. I'll make another PR to add one, but I would LOVE a bot that checked for the presence of a changelog entry.

@schneems schneems merged commit f90906c into master Sep 10, 2019
@schneems schneems deleted the bundler_binstubs_clean branch September 10, 2019 19:56
schneems added a commit that referenced this pull request Sep 10, 2019
schneems added a commit that referenced this pull request Sep 12, 2019
schneems added a commit that referenced this pull request Sep 12, 2019
@schneems
Copy link
Contributor

I deployed this, you should be able to use it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants